RFR[8239355]: '(dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)'

2020-03-09 Thread Patrick Concannon
Hi, Could someone please review my fix for JDK-8239355 '(dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)' ? By default, macOS imposes a size of 9216on Datagrams which limits applications that don't set the SO_SNDBUF option - legacy DatagramSocket sets the value to

8240754: Instrument FlowTest.java to provide more debug traces.

2020-03-09 Thread Daniel Fuchs
Hi, Please find below a changeset that adds some more debugging output to FlowTest.java for better test failure diagnosis. 8240754: Instrument FlowTest.java to provide more debug traces. https://bugs.openjdk.java.net/browse/JDK-8240754 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8240754/w

Re: RFR[8239355]: '(dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)'

2020-03-09 Thread Alan Bateman
On 09/03/2020 12:39, Patrick Concannon wrote: Hi, Could someone please review my fix for JDK-8239355 '(dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)' ? By default, macOS imposes a size of 9216on Datagrams which limits applications that don't set the SO_SNDBUF

Re: 8240754: Instrument FlowTest.java to provide more debug traces.

2020-03-09 Thread Chris Hegarty
Daniel, > On 9 Mar 2020, at 16:53, Daniel Fuchs wrote: > > Hi, > > Please find below a changeset that adds some more debugging > output to FlowTest.java for better test failure diagnosis. > > 8240754: Instrument FlowTest.java to provide more debug traces. > https://bugs.openjdk.java.net/browse

Re: RFR[8239355]: '(dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)'

2020-03-09 Thread Daniel Fuchs
Hi Alan, On 09/03/2020 17:01, Alan Bateman wrote: On 09/03/2020 12:39, Patrick Concannon wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8239355 webrev: http://cr.openjdk.java.net/~pconcannon/8239355/webrevs/webrev.00/index.html This is a change to the DatagramChannel implementation. I

Re: RFR[8239355]: '(dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)'

2020-03-09 Thread Alan Bateman
On 09/03/2020 18:08, Daniel Fuchs wrote: Hi Alan, On 09/03/2020 17:01, Alan Bateman wrote: On 09/03/2020 12:39, Patrick Concannon wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8239355 webrev: http://cr.openjdk.java.net/~pconcannon/8239355/webrevs/webrev.00/index.html This is a cha