Re: RFR[8236105]: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent

2020-01-17 Thread Chris Hegarty
Patrick, > On 13 Jan 2020, at 16:30, Patrick Concannon > wrote: > > Hi, > > Could someone please review my fix and CSR for issue JDK-8236105 'Behaviors > of DatagramSocket/DatagramChannel::socket send methods are not always > consistent' ? > > The behaviour of the send methods for DatagramS

Re: RFR[8236105]: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent

2020-01-17 Thread Patrick Concannon
Hi Chris, Thanks for your feedback. I've created a related bug for the points you've raised and I will take a look at them once this issue has been fixed. The new issue be found here: https://bugs.openjdk.java.net/browse/JDK-8237471 Kind regards, Patrick On 17/01/2020 12:03, Chris Heg

Re: RFR[8236105]: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent

2020-01-17 Thread Chris Hegarty
> On 17 Jan 2020, at 12:50, Patrick Concannon > wrote: > > Hi Chris, > > > > Thanks for your feedback. I've created a related bug for the points you've > raised and I will take a look at them once this issue has been fixed. > > The new issue be found here: https://bugs.openjdk.java.net/b

Re: RFR[8236105]: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent

2020-01-17 Thread Patrick Concannon
Hi Daniel, Well spotted. I've removed the line and updated the fix. It can be found in the new webrev below. http://cr.openjdk.java.net/~pconcannon/8236105/webrevs/webrev.01/ Kind regards, Patrick On 16/01/2020 10:40, Daniel Fuchs wrote: Hi Patrick, DatagramSocket.java:  694  *