Hi Patrick,
DatagramSocket.java:
694 * is not set.
this line needs to be removed.
Otherwise this looks good to me.
A release note might get requested by the CSR lead.
best regards,
-- daniel
On 13/01/2020 16:30, Patrick Concannon wrote:
Hi,
Could someone please review m
Daniel,
> On 13 Jan 2020, at 13:06, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a fix for:
> 8236859: WebSocket over authenticating proxy fails with NPE
> https://bugs.openjdk.java.net/browse/JDK-8236859
>
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8236859/webrev.00/
There is a lot
> On 14 Jan 2020, at 19:23, Alan Bateman wrote:
>
> ...
> Here's the updated webrev that changes oldImpl to be final.
>http://cr.openjdk.java.net/~alanb/8236925/2/webrev/
Generally, I agree with updating the socket adapter to support
multicast. It will certainly help with future work in t
On 16/01/2020 11:45, Chris Hegarty wrote:
:
Generally, I agree with updating the socket adapter to support
multicast. It will certainly help with future work in this area.
The instanceof checks in the constructors highlight that there is an
abstraction missing here - to support creating a custom
> On 16 Jan 2020, at 12:10, Alan Bateman wrote:
>
> On 16/01/2020 11:45, Chris Hegarty wrote:
>> :
>> Generally, I agree with updating the socket adapter to support
>> multicast. It will certainly help with future work in this area.
>>
>> The instanceof checks in the constructors highlight tha
