This is a patch to "upgrade" the DatagramChannel socket adaptor to
extend MulticastSocket. This is one of the final changes needed to
DatagramChannel and its socket adaptor buddy to make it easy to replace
the legacy DatagramSocket and MulticastSocket implementation. Daniel has
a draft JEP [1]
Hi Alan,
Thanks for the feedback.
I've incorporated your comments into the webrev below.
http://cr.openjdk.java.net/~pconcannon/8235783/webrevs/webrev.01/
Kind regards,
Patrick
On 18/12/2019 10:01, Alan Bateman wrote:
On 17/12/2019 14:35, Patrick Concannon wrote:
Hi,
Could someone please
On 10/01/2020 15:26, Patrick Concannon wrote:
Hi Alan,
Thanks for the feedback.
I've incorporated your comments into the webrev below.
http://cr.openjdk.java.net/~pconcannon/8235783/webrevs/webrev.01/
Thanks, this version looks good to me.
-Alan
Patrick.
> On 10 Jan 2020, at 15:26, Patrick Concannon
> wrote:
>
> Hi Alan,
>
> Thanks for the feedback.
>
> I've incorporated your comments into the webrev below.
>
> http://cr.openjdk.java.net/~pconcannon/8235783/webrevs/webrev.01/
Mostly looks good. A few small comments:
1) "If this **
Hi Chris,
Well spotted.
I've made those changes and updated the webrev.
http://cr.openjdk.java.net/~pconcannon/8235783/webrevs/webrev.02/
Kind regards,
Patrick
On 10/01/2020 16:17, Chris Hegarty wrote:
Patrick.
On 10 Jan 2020, at 15:26, Patrick Concannon
wrote:
Hi Alan,
Thanks for th
> On 10 Jan 2020, at 16:29, Patrick Concannon
> wrote:
>
> Hi Chris,
>
> Well spotted.
>
> I've made those changes and updated the webrev.
>
> http://cr.openjdk.java.net/~pconcannon/8235783/webrevs/webrev.02/
LGTM.
-Chris.
Looks good to me as well.
Is there a CSR ready to be reviewed too?
best regards,
-- daniel
On 10/01/2020 16:29, Patrick Concannon wrote:
Hi Chris,
Well spotted.
I've made those changes and updated the webrev.
http://cr.openjdk.java.net/~pconcannon/8235783/webrevs/webrev.02/
Kind regards,