Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2020-01-08 Thread Chris Hegarty
> On 8 Jan 2020, at 05:12, Anuraag Agrawal wrote: > > Hi Chris, > > Happy new year - sorry for the long delay. I have made an updated patch > fixing the comment (missing comma), bumping MAX_STR_LEN, and tweaking the > exception behavior. > > Basically, as you pointed out loadDNSConfig itself

Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2020-01-08 Thread Anuraag Agrawal
Hi Chris, Ah ok - I was worried it might be a backwards incompatible change, but I guess these are internal classes anyways. I have updated the patch, removing the exception handling logic so the errors propagate up. Inline patch follows diff --git a/src/java.base/windows/classes/sun/net/dns/Res

Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2020-01-08 Thread Aleks Efimov
Hi Anuraag, I've uploaded your latest patch to the following location: http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/04 The local Windows build and the acquired configuration are good. I will run you patch through our CI system and will update this thread once I get the results. Kind

Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2020-01-08 Thread Aleks Efimov
Got the testing results: the CI is happy with the last patch - no JNDI test failures observed Kind Regards, Aleksei On 08/01/2020 18:23, Aleks Efimov wrote: Hi Anuraag, I've uploaded your latest patch to the following location: http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/04 The loca