RFR [14] 8236441: Bound MulticastSocket fails when setting outbound interface on Windows

2019-12-20 Thread Chris Hegarty
The MulticastSocket implementation on Windows uses the two stacks implementation. The two stacks implementation creates a socket on the IPv4 stack and another on the IPv6 stack. Operations are then performed on both sockets as appropriate. If the socket is bound to a specific address, then the IP v

Re: RFR [14] 8236441: Bound MulticastSocket fails when setting outbound interface on Windows

2019-12-20 Thread Alan Bateman
On 20/12/2019 17:53, Chris Hegarty wrote: The MulticastSocket implementation on Windows uses the two stacks implementation. The two stacks implementation creates a socket on the IPv4 stack and another on the IPv6 stack. Operations are then performed on both sockets as appropriate. If the socket i

Re: RFR [14] 8236441: Bound MulticastSocket fails when setting outbound interface on Windows

2019-12-20 Thread Chris Hegarty
> On 20 Dec 2019, at 20:17, Alan Bateman wrote: > >> ... > This looks okay to me. There are a few inconsistencies in this code in that > some places it checks if fd1 >= 0, others != -1 but I don't think there are > correctness issues. You probably don't need to check ipv6_supported as fd1 >