RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

2019-12-13 Thread Kiran Ravikumar
Hi Guys, Could someone please review my fix to URI.java class were URI.compareTo(URI) behavior was different to URI.equals(URI). |URI.compareTo|(URI) does not consider two URI's to be equal when they differ only in the case of hexadecimal digits of escaped octets, while |URI.equals(URI)|does

Re: RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

2019-12-13 Thread Daniel Fuchs
Hi Kiran, 1926 int sn = s.length(); 1927 int tn = t.length(); could be moved before line 1921 which could then become: if (testForEquality && sn != tn) return sn - tn; Otherwise looks good. best regards, -- daniel On 13/12/2019 19:28, Kiran Ravikumar wro

(test-only) RFR: 8235925: java/net/Socket/HttpProxy.java fails on IPv4 only hosts and other small cleanups

2019-12-13 Thread Daniel Fuchs
Hi, Please find below a fix for: 8235925: java/net/Socket/HttpProxy.java fails on IPv4 only hosts and other small cleanups https://bugs.openjdk.java.net/browse/JDK-8235925 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8235925/webrev.00/index.html java/net/Socket/HttpProxy.java f