Re: RFR[8234148]: DatagramSocket.setOption/getOption/supportedOption should support multicast options

2019-12-09 Thread Patrick Concannon
Hi Daniel, Well spotted. I've updated that now, and you can find the changes in the new updated webrev below. http://cr.openjdk.java.net/~pconcannon/8234148/webrevs/webrev.01/ Kind regards, Patrick On 05/12/2019 16:01, Daniel Fuchs wrote: This looks good to me Patrick. With this fix mu

Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2019-12-09 Thread Aleks Efimov
Hi Anuraag, The webrev with your latest changes can be found here:     http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/01 The copyright changes looks good. The split by space also looks good with assumption that we will never get string with two spaces between IP addresses/DNS suffixes.

RFR 8234871: deprecate SocketFlow (SO_FLOW_SLA) and related APIs for removal

2019-12-09 Thread Michael McMahon
Hi, Could I get the following webrev reviewed please? The deprecation arises from the general deprecation of the Solaris port and the fact this is a Solaris only feature. http://cr.openjdk.java.net/~michaelm/8234871/webrev.1/ Thanks, Michael.

Re: RFR 8234871: deprecate SocketFlow (SO_FLOW_SLA) and related APIs for removal

2019-12-09 Thread Chris Hegarty
> On 9 Dec 2019, at 18:03, Michael McMahon wrote: > > Hi, > > Could I get the following webrev reviewed please? The deprecation arises from > the general deprecation of the Solaris port and the fact this is a Solaris > only feature. > > http://cr.openjdk.java.net/~michaelm/8234871/webrev.1/

Re: RFR 8234871: deprecate SocketFlow (SO_FLOW_SLA) and related APIs for removal

2019-12-09 Thread Alan Bateman
On 09/12/2019 18:03, Michael McMahon wrote: Hi, Could I get the following webrev reviewed please? The deprecation arises from the general deprecation of the Solaris port and the fact this is a Solaris only feature. http://cr.openjdk.java.net/~michaelm/8234871/webrev.1/ Looks okay to me. -A

Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2019-12-09 Thread Anuraag Agrawal
Hi Aleksei, Thanks for running the test. I had checked the global search list, but realize I didn't check connection-specific suffixes which were causing the issue you see. While the documentation states that FirstDnsSuffix is populated on Vista+, amazingly it doesn't seem to be https://docs.micr