Could I get the following two trivial test case fixes reviewed please?
They are both caused by a recent configuration change to Windows 10
where socket connect
requests are attempted four times, at 500ms intervals, on connection
refused errors,
which means that such connects will take around 2
On 03/12/2019 09:59, Michael McMahon wrote:
:
8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2()
fails on Windows 10
http://cr.openjdk.java.net/~michaelm/8234823/webrev.1/
For this one, it should be okay to increase the timeout to a much larger
timeout if you want. For exampl
Thanks Alan. Yes, I think it's reasonable to set a much larger timeout.
The actual delay experienced (annoying as it is) will still be only two
seconds.
I'll go ahead with that.
Michael.
On 03/12/2019 11:08, Alan Bateman wrote:
On 03/12/2019 09:59, Michael McMahon wrote:
:
8234823: java/n
Thanks for the review Alan!
new webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.01/
On 02/12/2019 15:53, Alan Bateman wrote:
8235141: Specify the required standard socket options for the
socket types in the java.net package
https://bugs.openjdk.java.net/browse/JDK-8235
On 03/12/2019 16:39, Daniel Fuchs wrote:
It's true that there might be some overlap. This test is more about
proving consistency between the doc and the different implementations
provided by the JDK. It's too easy for something to fall through the
gaps otherwise.
The javadoc update looks good.
