On 14/11/2019 12:24, Patrick Concannon wrote:
Hi Daniel,
I've added the comment, and you can find it in the new webrev below.
webrev: http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.01/
Looks good Patrick - I think we could push that if you can generate
a properly formatted cha
> On 14/11/2019 12:24, Patrick Concannon wrote:
>> ..
>> webrev: http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.01/
LGTM.
-Chris.
Hi Patrick,
This looks good to me!
best regards,
-- daniel
On 14/11/2019 12:19, Patrick Concannon wrote:
Hi,
Could someone please review my fix for issue JDK-8233018 'Add a new test
to verify that DatagramSocket is not interruptible'?
This fix adds a test to check the interruptability of
> On 20 Nov 2019, at 12:23, Daniel Fuchs wrote:
>
> Hi Patrick,
>
> This looks good to me!
+1
-Chris.
>
> best regards,
>
> -- daniel
>
> On 14/11/2019 12:19, Patrick Concannon wrote:
>> Hi,
>> Could someone please review my fix for issue JDK-8233018 'Add a new test to
>> verify that
Hello, please review this small cleanup .
While experimenting with "link time gc" (-Wl,--gc-sections
-Wl,--print-gc-sections options [1]), a feature that can help you identify
and eliminate unused coding,
I noticed that NET_ReadV is found and marked as unused/dead code. So it should
proba
looks OK to me, i searched through entire JDK code base and i did not found any uses of "NET_ReadV" .
Thanks,
Vyom
- Original message -From: "Baesken, Matthias" Sent by: "net-dev" To: "net-dev@openjdk.java.net" Cc:Subject: [EXTERNAL] RFR: [XS] 8234501 : remove obsolete NET_ReadVDate: W
Thanks !
May I have a second review ?
Best regards, Matthias
From: Vyom Tewari26
Sent: Donnerstag, 21. November 2019 05:01
To: Baesken, Matthias
Cc: net-dev@openjdk.java.net
Subject: Re: RFR: [XS] 8234501 : remove obsolete NET_ReadV
looks OK to me, i searched through entire JDK code base and
On 21/11/2019 07:38, Baesken, Matthias wrote:
Thanks !
May I have a second review ?
Looks good.
-Alan
