On 04/11/2019 15:09, Daniel Fuchs wrote:
:
It looks like Cache#remove can be fixed simply by using an explicit
iterator and using iterator#remove instead of List#remove.
Yes - we could have used an Iterator. I don't like much LinkedList.
We could have used ArrayList and an explicit Iterator i
Hi Chris,
Thanks for the review! Meanwhile one of the test jobs I had
launched completed and showed one of the intermittent
SortRequestBody failures - and I was able to see the root
cause!
It is a test bug: the server uses a counter to figure out
what result the client will expect in its next re
> On 5 Nov 2019, at 14:45, Daniel Fuchs wrote:
>
> Hi Chris,
>
> Thanks for the review! Meanwhile one of the test jobs I had
> launched completed and showed one of the intermittent
> SortRequestBody failures - and I was able to see the root
> cause!
Great.
> It is a test bug: the server use
On 05/11/2019 15:25, Chris Hegarty wrote:
So the server is getting a connection from “something else” on on the network,
and your changes protect against that, right? Is there any value, from a
diagnostic point of view, to emitting whatever “unexpected” data is received?
Ah - no. Actually the
> On 5 Nov 2019, at 15:36, Daniel Fuchs wrote:
>
> On 05/11/2019 15:25, Chris Hegarty wrote:
>> So the server is getting a connection from “something else” on on the
>> network, and your changes protect against that, right? Is there any value,
>> from a diagnostic point of view, to emitting
Thanks for the feedback everyone.
It looks like Cache#remove can be fixed simply by using an explicit
iterator and using iterator#remove instead of List#remove.
Cache looks fishy in other ways, e.g. why does Cache#remove ignore
authscheme?
I changed the implementation to use an iterator in
Thanks Julia!
The changes look good to me.
best regards,
-- daniel
On 05/11/2019 15:38, Julia Boes wrote:
Updated webrev:
http://cr.openjdk.java.net/~jboes/webrevs/8232853/webrev.02/index.html
I filed a separate issue to revisit the cache implementation:
https://bugs.openjdk.java.net/brows
Hi Julia,
Your new iterator approach looks good to me. one minor comment as you are using 'var' language construct the variable name 'au' is not a meaning full name .
Thanks,
Vyom
- Original message -From: Julia Boes Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERN
