Re: RFR: 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact

2019-10-29 Thread Julia Boes
Hi, Based on Joe's feedback the specification change was turned from an @apiNote to an extension of the method description. See updated CSR: https://bugs.openjdk.java.net/browse/JDK-8232600 Thanks, Julia

Re: RFR: 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact

2019-10-29 Thread Julia Boes
..and the updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231632/webrev.03/ On 29/10/2019 12:53, Julia Boes wrote: Hi, Based on Joe's feedback the specification change was turned from an @apiNote to an extension of the method description. See updated CSR: https://bugs.openjdk.jav

Re: RFR: 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact

2019-10-29 Thread Daniel Fuchs
Looks good to me Julia! best regards, -- daniel On 29/10/2019 13:01, Julia Boes wrote: ..and the updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231632/webrev.03/ On 29/10/2019 12:53, Julia Boes wrote: Hi, Based on Joe's feedback the specification change was turned from an @api

Re: RFR: 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact

2019-10-29 Thread Chris Hegarty
> On 29 Oct 2019, at 13:01, Julia Boes wrote: > > ..and the updated webrev: > http://cr.openjdk.java.net/~jboes/webrevs/8231632/webrev.03/ Ship it! -Chris.