Re: RFR: 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses

2019-10-16 Thread Julia Boes
Hi Daniel, Thanks for reviewing the change. I added a test case as per your suggestion. Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.01/index.html Regards, Julia On 15/10/2019 14:22, Daniel Fuchs wrote: Hi Julia, This looks good to me. On the test - maybe we s

Re: RFR: 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses

2019-10-16 Thread Chris Hegarty
On 16/10/2019 10:38, Julia Boes wrote: Hi Daniel, Thanks for reviewing the change. I added a test case as per your suggestion. Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.01/index.html LGTM. -Chris.

Re: RFR[8231719 ]: Correct contradictions in timeout range descriptions

2019-10-16 Thread Daniel Fuchs
Thanks Patrick, Looks good to me as well. best regards, -- daniel On 11/10/2019 11:54, Patrick Concannon wrote: Hi, Could someone please review my fix and CSR for JDK-8231719 'Correct contradictions in timeout range descriptions' ? The

Re: RFR: 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses

2019-10-16 Thread Daniel Fuchs
Looks good! best regards, -- daniel On 16/10/2019 10:38, Julia Boes wrote: Hi Daniel, Thanks for reviewing the change. I added a test case as per your suggestion. Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.01/index.html Regards, Julia

RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-16 Thread Patrick Concannon
Hi, Could someone please review my fix and CSR for issue JDK-8231570 '(dc) Clarify implicit bind behavior of DatagramChannel' ? The fix clarifies the security checks for DatagramChannel connect, send, and receive methods. webrev: http://cr.openjdk.java.net/~pconcannon/8231570/webrevs/webr

RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-16 Thread Patrick Concannon
[Resending with nio-dev in cc] Hi, Could someone please review my fix and CSR for issue JDK-8231570 '(dc) Clarify implicit bind behavior of DatagramChannel' ? The fix clarifies the security checks for DatagramChannel connect, send, and receive methods. webrev: http://cr.openjdk.java.net/

Re: RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-16 Thread Alan Bateman
On 16/10/2019 19:20, Patrick Concannon wrote: : webrev: http://cr.openjdk.java.net/~pconcannon/8231570/webrevs/webrev.02/ Looks good.