Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

Hi Mark, On 07/10/2019 16:09, mark sheppard wrote: Hi Daniel,    wrt impl note ... would some explanation on the esoteric reason for a now possible BindException  be useful, also? [...] the output will show a java.net.BindException, which is sort of arcane for a disconnect ? There is such

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

Hi Daniel,     thanks for the reply 👍 I also meant to add that as on the ln 947   localAddress = isa; so in the event of the Net.bind() throwing a BindException then the localAddress in DatgramSocket instance will have a port == 0, indicating that it is unbound ? if the localAddress.getPort() =

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

On 08/10/2019 15:20, mark sheppard wrote: : Q: is localAddress.getPort() == 0 indicative that the DatagramChannel is unbound ? getLocalAddress() returns a SocketAddress when bound, it returns null when not bound. I don't think we should get too hung up on corner case that arises when the

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

On 08/10/2019 15:29, Alan Bateman wrote: On 08/10/2019 15:20, mark sheppard wrote: : Q: is  localAddress.getPort() == 0   indicative that the DatagramChannel is unbound ? getLocalAddress() returns a SocketAddress when bound, it returns null when not bound. I don't think we should get too hu

RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

Hi Guys, Could you please review this minor fix: Bug :https://bugs.openjdk.java.net/browse/JDK-8214560 Webrev :https://cr.openjdk.java.net/~coffeys/webrev.8214560/webrev/ Explanation : Added the javadoc tag @systemProperty to syst

Re: RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

Hi Kiran, Looks good to me. Did you generate the docs and verify the change has the expected effects? best regards, -- daniel On 08/10/2019 17:19, Kiran Ravikumar wrote: Hi Guys, Could you please review this minor fix: Bug :https://bugs.openjdk.java.net/browse/JDK-8214560 Webrev :https://cr

Re: RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

On 08/10/2019, 17:51, Daniel Fuchs wrote: Hi Kiran, Looks good to me. Did you generate the docs and verify the change has the expected effects? best regards, -- daniel On 08/10/2019 17:19, Kiran Ravikumar wrote: Hi Guys, Could you please review this minor fix: Bug :https://bugs.openjdk.jav

Re: RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

Looks good Kiran. I'll sponsor this for you. regards, Sean. On 08/10/2019 17:19, Kiran Ravikumar wrote: Hi Guys, Could you please review this minor fix: Bug :https://bugs.openjdk.java.net/browse/JDK-8214560 Webrev :https://cr.openjdk.java.net/~coffeys/webrev.8214560/webrev/