RFR[8217825]: Verify @AfterTest is used correctly in WebSocket tests

2019-09-13 Thread Patrick Concannon
Hi, 

 Would it be possible to have my fix for JDK-8217825 - Verify @AfterTest is used correctly in WebSocket tests - reviewed? Following on from the discussion had here: https://mail.openjdk.java.net/pipermail/net-dev/2019-January/012141.html, I’ve refactored several websocket tests to exp

Re: RFR[8217825]: Verify @AfterTest is used correctly in WebSocket tests

2019-09-13 Thread Daniel Fuchs
Hi Patrick, I wonder if you should be using `try { } finally { }` to ensure that the websocket is closed too: var websocket = .; try { // send some messages etc... } finally { websocket.abort(); } best regards, -- daniel On 13/09/2019 15:36, Patrick Concannon w