Hi,
Please find below a trivial fix for:
8230694: http.keepAlive system property is inconsistently/incorrectly
documented
https://bugs.openjdk.java.net/browse/JDK-8230694
The net-properties.html has a typo in the name of the http.keepAlive
network property: it should read `http.keepAli
On 06/09/2019 13:52, Daniel Fuchs wrote:
:
The net-properties.html has a typo in the name of the http.keepAlive
network property: it should read `http.keepAlive` not `http.keepalive`.
Looks good.
> On 6 Sep 2019, at 13:52, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a trivial fix for:
>
> 8230694: http.keepAlive system property is inconsistently/incorrectly
> documented
> https://bugs.openjdk.java.net/browse/JDK-8230694
>
> The net-properties.html has a typo in the name
Hi,
Please find below a fix for:
8230526: jdk.internal.net.http.PlainProxyConnection is never reused
by HttpClient
https://bugs.openjdk.java.net/browse/JDK-8230526
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8230526/webrev.00/
Indeed, the new HttpClient never reuses plain proxy c
Hi Jaikiran,
You went a little further than just removing the superfluous
hyphen but I think that's OK.
You can count me as Reviewer. If nobody objects I'll hopefully
push that for you later today.
best regards,
-- daniel
On 04/09/2019 11:55, Jaikiran Pai wrote:
Ping. Anyone willing to review
Thanks Patrick,
Looks good to me.
With Best Regards,
Aleksei
On 04/09/2019 12:14, Patrick Concannon wrote:
Hey Aleksei,
Good idea. I've made that change, and it can be found in the webrev below.
http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.2/
Kind regards,
Patrick
Thank you for the review and sponsoring, Daniel. I've updated the webrev
at the same location[1] to include you as the reviewer.
[1] http://cr.openjdk.java.net/~jpai/webrev/8177389/1/webrev/
-Jaikiran
On 06/09/19 6:28 PM, Daniel Fuchs wrote:
> Hi Jaikiran,
>
> You went a little further than just