RFR: 8230694: http.keepAlive system property is inconsistently/incorrectly documented

2019-09-06 Thread Daniel Fuchs
Hi, Please find below a trivial fix for: 8230694: http.keepAlive system property is inconsistently/incorrectly documented https://bugs.openjdk.java.net/browse/JDK-8230694 The net-properties.html has a typo in the name of the http.keepAlive network property: it should read `http.keepAli

Re: RFR: 8230694: http.keepAlive system property is inconsistently/incorrectly documented

2019-09-06 Thread Alan Bateman
On 06/09/2019 13:52, Daniel Fuchs wrote: : The net-properties.html has a typo in the name of the http.keepAlive network property: it should read `http.keepAlive` not `http.keepalive`. Looks good.

Re: RFR: 8230694: http.keepAlive system property is inconsistently/incorrectly documented

2019-09-06 Thread Chris Hegarty
> On 6 Sep 2019, at 13:52, Daniel Fuchs wrote: > > Hi, > > Please find below a trivial fix for: > > 8230694: http.keepAlive system property is inconsistently/incorrectly > documented > https://bugs.openjdk.java.net/browse/JDK-8230694 > > The net-properties.html has a typo in the name

RFR: 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient

2019-09-06 Thread Daniel Fuchs
Hi, Please find below a fix for: 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient https://bugs.openjdk.java.net/browse/JDK-8230526 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8230526/webrev.00/ Indeed, the new HttpClient never reuses plain proxy c

Re: RFR: JDK-8177389: Hyphen "-" should be removed in URL class documentation

2019-09-06 Thread Daniel Fuchs
Hi Jaikiran, You went a little further than just removing the superfluous hyphen but I think that's OK. You can count me as Reviewer. If nobody objects I'll hopefully push that for you later today. best regards, -- daniel On 04/09/2019 11:55, Jaikiran Pai wrote: Ping. Anyone willing to review

Re: RFR[8230132]: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface

2019-09-06 Thread Aleks Efimov
Thanks Patrick, Looks good to me. With Best Regards, Aleksei On 04/09/2019 12:14, Patrick Concannon wrote: Hey Aleksei, Good idea. I've made that change, and it can be found in the webrev below. http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.2/ Kind regards, Patrick

Re: RFR: JDK-8177389: Hyphen "-" should be removed in URL class documentation

2019-09-06 Thread Jaikiran Pai
Thank you for the review and sponsoring, Daniel. I've updated the webrev at the same location[1] to include you as the reviewer. [1] http://cr.openjdk.java.net/~jpai/webrev/8177389/1/webrev/ -Jaikiran On 06/09/19 6:28 PM, Daniel Fuchs wrote: > Hi Jaikiran, > > You went a little further than just