Hi,
On 02/09/2019 05:29, Vyom Tewari26 wrote:
2-> i think super.stop() should be the first line in the
overridden stop method.
I had thought of this when I introduced the change. However, I felt
that it's better to set the stop=true before calling the
super.stop(), since th
Hi,
Would it be possible to have my fix for JDK-8230159 reviewed?
Test added to verify that com/sun/net/httpserver/BasicAuthenticator
constructors throw expected exceptions.
The com/sun/net/httpserver/BasicAuthenticator constructors specifies
that NullPointerException will be thrown if r
Hello Vyom, Daniel,
On 02/09/19 3:00 PM, Daniel Fuchs wrote:
> Hi,
>
> On 02/09/2019 05:29, Vyom Tewari26 wrote:
>>> 2-> i think super.stop() should be the first line in the
>>> overridden stop method.
>>
>> I had thought of this when I introduced the change. However, I felt
>> tha
Thanks for the update Jaikiran!
This looks good to me. I will import it in my repo and test it
for a while...
best regards,
-- daniel
On 02/09/2019 12:23, Jaikiran Pai wrote:
This does look better. I have updated the code to use this construct and
the new webrev is at
http://cr.openjdk.java.n
Hi,
(cc-ing security dev for the changes in
test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java
which is updated to allow for binding on a specific
IP Address)
Please find below a patch for:
8230435: Replace wildcard address with loopback or local host
in tests - part 22
https://
Hey Patrick,
Looks good to me!
You could utilize jdk.test.lib.Platform::isWindows from test library to
check if the test is running on Windows platform.
With Best Regards,
Aleksei
On 29/08/2019 16:01, Patrick Concannon wrote:
Hi,
Would it be possible to have my fix for JDK-8230132 reviewe
Hi,
Thanks for the review, Michael and Vyom. I removed server.close() from
the run method.
Updated webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8171405/webrev.03/
Regards,
Julia
On 01/09/2019 06:07, Vyom Tewari26 wrote:
Hi Julia,
Thanks for fixing this test issue, in your modified code
