Hello Daniel,
Here's an updated webrev which includes a test case to verify this
change http://cr.openjdk.java.net/~jpai/webrev/8230310/2/webrev/
-Jaikiran
On 29/08/19 9:12 AM, Jaikiran Pai wrote:
> Hello Daniel,
>
> On 28/08/19 8:45 PM, Daniel Fuchs wrote:
>> Hi Jaikiran,
>>
>> On 28/08/2019 15
Thanks for the test Jaikiran!
Since an IOException is expected at line 76, I believe
it would be good for the test to trow an assertion error
if that doesn't happen.
Maybe simply insert:
throw new AssertionError("expected exception not thrown");
between lines 75 and 76?
best regards,
-- dan
Hello Daniel,
On 29/08/19 2:56 PM, Daniel Fuchs wrote:
> Thanks for the test Jaikiran!
>
> Since an IOException is expected at line 76, I believe
> it would be good for the test to trow an assertion error
> if that doesn't happen.
>
> Maybe simply insert:
> throw new AssertionError("expected ex
Thanks! Looks fine. I see you have used Assert.fail and that's
better than what I suggested.
I can be your sponsor if you want. Count me as Reviewer!
best regards,
-- daniel
On 29/08/2019 10:48, Jaikiran Pai wrote:
Maybe simply insert:
throw new AssertionError("expected exception not thro
On 29/08/19 3:54 PM, Daniel Fuchs wrote:
> Thanks! Looks fine. I see you have used Assert.fail and that's
> better than what I suggested.
>
> I can be your sponsor if you want. Count me as Reviewer!
Yes please. I have updated the webrev at the same location, with just an
update to the Reviewed-b
Hi,
Would it be possible to have my fix for JDK-8230132 reviewed?
java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java was
failing intermittently on Windows due to random addresses being returned
from the virtual interface "Teredo Tunneling Pseudo-Interface". The fix
checks for, and
Hi,
This fix involves a test that failed during thread cleanup. To address
this, the ServerSocket is now being closed at the end and the server
thread is joined. While at it, I removed some unnecessary whitespace.
webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8171405/webrev.02/
bug report
