RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

Hi, Please find below a patch for: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request https://bugs.openjdk.java.net/browse/JDK-8185898 According to RFC 2616 , message headers of a HTTP message must adhere to

Re: RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

Hi Julia, I will sponsor this for you. Trivially, there are a couple of unnecessary blank lines inserted at the top of MessageHeader.java. I think the @summary in the new test might be better just having the original bug synopsis in this case. Otherwise, looks fine. Thanks, Michael. On 31/0

Re: RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

Hi Julia, Could you verify that `HttpURLConnection::getHeaderField(0)` and `HttpURLConnection::getHeaderFieldKey(0)` return the same thing before and after the fix, for all implementations of `HttpURLConnection` in the JDK? I believe your test is missing that. More specifically, I'm referring t

Re: RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

Daniel I don't think the change affects the usage of response headers, but it might be useful to include in the test a call to getHeaderField(0) to verify that. Michael. On 31/07/2019, 12:30, Daniel Fuchs wrote: Hi Julia, Could you verify that `HttpURLConnection::getHeaderField(0)` and `HttpU

Re: RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

Hi Michael, On 31/07/2019 14:47, Michael McMahon wrote: Daniel I don't think the change affects the usage of response headers, but it might be useful to include in the test a call to getHeaderField(0) to verify that. Oh - right - but it will/might affect the toString() of the response headers