Re: RFR: 8225239: Refactor NetworkInterface lookups

2019-07-05 Thread Michael McMahon
Claes, This is great work and long overdue. Thanks for taking care of it. - Michael. On 04/07/2019, 20:20, Claes Redestad wrote: Hi, please review this patch that refactors native java.net.NetworkInterface lookup logic in a few ways to address both pre-existing and recent regressions: Bug:

Re: RFR: 8225239: Refactor NetworkInterface lookups

2019-07-05 Thread Daniel Fuchs
Hi Claes, That looks like a good cleanup and improvement. Thanks for having looked into this! best regards, -- daniel On 04/07/2019 21:20, Claes Redestad wrote: Hi, please review this patch that refactors native java.net.NetworkInterface lookup logic in a few ways to address both pre-existin

Re: RFR: 8225239: Refactor NetworkInterface lookups

2019-07-05 Thread Claes Redestad
Thanks, Michael! /Claes On 2019-07-05 10:02, Michael McMahon wrote: Claes, This is great work and long overdue. Thanks for taking care of it. - Michael. On 04/07/2019, 20:20, Claes Redestad wrote: Hi, please review this patch that refactors native java.net.NetworkInterface lookup logic in

Re: RFR: 8225239: Refactor NetworkInterface lookups

2019-07-05 Thread Claes Redestad
Thanks, Daniel! /Claes On 2019-07-05 12:07, Daniel Fuchs wrote: Hi Claes, That looks like a good cleanup and improvement. Thanks for having looked into this! best regards, -- daniel On 04/07/2019 21:20, Claes Redestad wrote: Hi, please review this patch that refactors native java.net.Netw