RFR [13] 8224973: URLStreamHandler.openConnection(URL,Proxy) - spec and implementation mismatch

2019-05-30 Thread Chris Hegarty
The current default implementation of openConnection(URL,Proxy) simply throws UnsupportedOperationException. Pedantically, this violates its own specification, since it does not throw IllegalArgumentException when passed a null value. To resolve this, the default implementation should be updated a

Re: RFR [13] 8224973: URLStreamHandler.openConnection(URL,Proxy) - spec and implementation mismatch

2019-05-30 Thread Alan Bateman
On 30/05/2019 12:04, Chris Hegarty wrote: The current default implementation of openConnection(URL,Proxy) simply throws UnsupportedOperationException. Pedantically, this violates its own specification, since it does not throw IllegalArgumentException when passed a null value. To resolve this, th

RFR [13] 8225060: java.net.DefaultInterface invokes NetworkInterface::getInetAddresses without doPriv

2019-05-30 Thread Chris Hegarty
The test for 8224730 [1] exposes an issue in the macOS package-private java.net.DefaultInterface - NetworkInterface::getInetAddresses is invoked without a doPriv. DefaultInterface is loaded by NetworkInterface's static initializer. Example stacktrace, as seen from java/net/ServerSocket/TestLocalAd

Re: RFR [13] 8225060: java.net.DefaultInterface invokes NetworkInterface::getInetAddresses without doPriv

2019-05-30 Thread Alan Bateman
This looks okay. Hopefully we can get rid of this code as part of the fix for 8216417. -Alan On 30/05/2019 15:54, Chris Hegarty wrote: The test for 8224730 [1] exposes an issue in the macOS package-private java.net.DefaultInterface - NetworkInterface::getInetAddresses is invoked without a doPr

Re: RFR [13] 8224973: URLStreamHandler.openConnection(URL,Proxy) - spec and implementation mismatch

2019-05-30 Thread Daniel Fuchs
Looks fine Chris! best regards, -- daniel On 30/05/19 12:04, Chris Hegarty wrote: The current default implementation of openConnection(URL,Proxy) simply throws UnsupportedOperationException. Pedantically, this violates its own specification, since it does not throw IllegalArgumentException whe