RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770

Hi, I found build is failed on CentOS 7.6, because of loop initial declarations. Could I please get reviews for this? Bug: https://bugs.openjdk.java.net/browse/JDK-8224028 Webrev: http://cr.openjdk.java.net/~aoqi/8224028/webrev.00/ Tested: linux-x86_64-server-release tier1 Thanks, Ao Qi

Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

Hi Mark, AFAIU the test wants to verify that connections are reused. It does that by creating N (N=5) threads that will hammer at the server concurrently. Because there are N threads, then there can't be more than N concurrent requests, and therefore there should not be more than N connections a

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi Ao Qi, I'm adding serviceability-dev, since this is for jdwp. The proposed changes look good to me - but please get someone from the serviceability team to review this. best regards, -- daniel On 16/05/2019 08:41, Ao Qi wrote: Hi, I found build is failed on CentOS 7.6, because of loop i

Re: [ipv6]: 8224014: Don't run test/jdk/java/net/NetworkInterface/IPv4Only.java in IPv6 only environment

Hi Arthur, Looks good to me. Reviewed. best regards, -- daniel On 16/05/2019 00:24, Arthur Eubanks wrote: webrev: http://cr.openjdk.java.net/~aeubanks/8224014/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8224014 In https://bugs.openjdk.java.net/browse/JDK-8220673, I missed skippi

Re: [ipv6]: 8224019: test/jdk/java/nio/channels/DatagramChannel/BasicMulticastTests.java assumes IPv4 is always available

Hi Arthur, Shouldn't there be a version of 221 exceptionTests(nif); that works with IPv6? If no machine has IPv4 available, then these exceptions won't be tested any more. I suspect the test made the assumption that IPv4 was always available, and therefore testing exceptions with I

Re: [ipv6]: 8224018: test/jdk/java/net/ipv6tests/{Tcp,Udp}Test.java assume IPv4 is available

Hi Arthur, Looks good to me! best regards, -- daniel On 16/05/2019 01:46, Arthur Eubanks wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8224018 webrev: http://cr.openjdk.java.net/~aeubanks/8224018/webrev.00/ test/jdk/java/net/ipv6tests/{Tcp,Udp}Test.java both assume that IPv4 is avail

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi Ao Qi, It looks good to me. Thank you for taking care about it! One minor comment on the fragment: 474 if (mask != NULL) { 475 if (parseAllowedMask(mask, isIPv4, &(_peers[_peers_cnt].netmask)) != JDWPTRANSPORT_ERROR_NONE) {

Re: [ipv6]: 8224018: test/jdk/java/net/ipv6tests/{Tcp,Udp}Test.java assume IPv4 is available

+1 -Chris. > On 16 May 2019, at 10:56, Daniel Fuchs wrote: > > Hi Arthur, > > Looks good to me! > > best regards, > > -- daniel > > On 16/05/2019 01:46, Arthur Eubanks wrote: >> bug: https://bugs.openjdk.java.net/browse/JDK-8224018 >> webrev: http://cr.openjdk.java.net/~aeubanks/8224018/web

Re: [ipv6]: 8224014: Don't run test/jdk/java/net/NetworkInterface/IPv4Only.java in IPv6 only environment

Arthur, > On 16 May 2019, at 00:24, Arthur Eubanks wrote: > > webrev: http://cr.openjdk.java.net/~aeubanks/8224014/webrev.00/ > > bug: https://bugs.openjdk.java.net/browse/JDK-8224014 >

Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

Hi Daniel, thanks for the reply and clarifications apologies for the distraction regards Mark From: Daniel Fuchs Sent: Thursday 16 May 2019 09:19 To: mark sheppard; Chris Hegarty; OpenJDK Network Dev list Subject: Re: RFR: 8223716: sun/net/www/http/HttpClie

[teststabilization] RFR: 8223856: Replace wildcard address with loopback or local host in tests - part 8

Hi, Please find below a fix for [1]: 8223856: Replace wildcard address with loopback or local host in tests - part 8 http://cr.openjdk.java.net/~dfuchs/webrev_8223856/webrev.00/index.html Some of the test failures weren't all attributable to the use of the wildcard: in some cases tests

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

What compiler was used here? We shouldn't be using anything that doesn't handle loop variable declarations! Thanks, David On 16/05/2019 7:41 pm, Daniel Fuchs wrote: Hi Ao Qi, I'm adding serviceability-dev, since this is for jdwp. The proposed changes look good to me - but please get someone

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi Serguei, I saw your email [1], but I didn't receive it yet. Thanks for your review! I updated: http://cr.openjdk.java.net/~aoqi/8224028/webrev.01/ On Thu, May 16, 2019 at 8:30 PM David Holmes wrote: > > What compiler was used here? We shouldn't be using anything that doesn't > handle loop va

Re: [teststabilization] RFR: 8223856: Replace wildcard address with loopback or local host in tests - part 8

Hi Daniel, The changes looks good to me! Best Regards, Aleksei On 16/05/2019 13:23, Daniel Fuchs wrote: Hi, Please find below a fix for [1]: 8223856: Replace wildcard address with loopback or local host in tests - part 8 http://cr.openjdk.java.net/~dfuchs/webrev_8223856/webrev.00/i

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 05/16/2019 06:41, Ao Qi wrote: Hi Serguei, I saw your email [1], but I didn't receive it yet. Thanks for your review! I updated: http://cr.openjdk.java.net/~aoqi/8224028/webrev.01/ Looks good. --alex On Thu, May 16, 2019 at 8:30 PM David Holmes wrote: What compiler was used here?

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi Ao Qi, Thank you for the update. It looks good to me. Do you need a sponsor for integration? Thanks, Serguei On 5/16/19 09:38, Alex Menkov wrote: On 05/16/2019 06:41, Ao Qi wrote: Hi Serguei, I saw your email [1], but I didn't receive it yet. Thanks for your review! I updated: http:/

Re: [ipv6]: 8224014: Don't run test/jdk/java/net/NetworkInterface/IPv4Only.java in IPv6 only environment

*From: *Chris Hegarty *Date: *Thu, May 16, 2019 at 3:52 AM *To: *Arthur Eubanks *Cc: *OpenJDK Network Dev list Arthur, > > On 16 May 2019, at 00:24, Arthur Eubanks wrote: > > webrev: http://cr.openjdk.java.net/~aeubanks/8224014/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-8224014 >

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On Fri, May 17, 2019 at 12:44 AM serguei.spit...@oracle.com wrote: > > Hi Ao Qi, > > Thank you for the update. > It looks good to me. Thanks! > > Do you need a sponsor for integration? Yes:) > > Thanks, > Serguei > > > On 5/16/19 09:38, Alex Menkov wrote: > > > > > > On 05/16/2019 06:41, Ao Qi

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

On 5/14/19 9:16 PM, Martin Buchholz wrote: src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java Regarding the change in this particular file, I'd suggest the following: diff -r 006dadb903ab -r 92e1fdce45e0 src/java.base/share/classes/java/util/concurrent/ConcurrentS

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 17/05/2019 12:26 am, Jean Christophe Beyler wrote: From my experience, some compiler in Solaris/Windows complain about this (or used to a year ago via the submit repo); Serguei and I had to do this dance when we were getting the heap monitoring tests in. An I think the tests are different

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 16/05/2019 11:41 pm, Ao Qi wrote: Hi Serguei, I saw your email [1], but I didn't receive it yet. Thanks for your review! I updated: http://cr.openjdk.java.net/~aoqi/8224028/webrev.01/ On Thu, May 16, 2019 at 8:30 PM David Holmes wrote: What compiler was used here? We shouldn't be using a

Re: [ipv6]: 8224019: test/jdk/java/nio/channels/DatagramChannel/BasicMulticastTests.java assumes IPv4 is always available

I've added testing exceptions to IPv6 as well, PTAL. This required hardcoding IPv4 and IPv6 loopback addresses for the IPv4 and IPv6 code paths. Else DatagramChannel.join() fails since you can't mix IPv4 and IPv6 addresses, and InetAddress.getLocalHost() can only be one of those. http://cr.openjdk

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Maybe you just need to ask gcc to use a more modern -std=... It might reasonably be defaulting to gnu89 https://stackoverflow.com/questions/14737104/what-is-the-default-c-mode-for-the-current-gcc-especially-on-ubuntu On Thu, May 16, 2019 at 3:25 PM David Holmes wrote: > On 16/05/2019 11:41 pm, A

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 17/05/2019 8:57 am, Martin Buchholz wrote: Maybe you just need to ask gcc to use a more modern -std=... It might reasonably be defaulting to gnu89 https://stackoverflow.com/questions/14737104/what-is-the-default-c-mode-for-the-current-gcc-especially-on-ubuntu Yes, but I thought we'd already

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On Thu, May 16, 2019 at 4:05 PM David Holmes wrote: > On 17/05/2019 8:57 am, Martin Buchholz wrote: > > Maybe you just need to ask gcc to use a more modern -std=... > > It might reasonably be defaulting to gnu89 > > > https://stackoverflow.com/questions/14737104/what-is-the-default-c-mode-for-the

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 17/05/2019 9:14 am, Martin Buchholz wrote: On Thu, May 16, 2019 at 4:05 PM David Holmes > wrote: On 17/05/2019 8:57 am, Martin Buchholz wrote: > Maybe you just need to ask gcc to use a more modern -std=... > It might reasonably be defaulting to gn

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Stuart's cool type system hack is hard for me to grok, but it seems alright to put into ConcurrentSkipListMap.java. We could add it to the current jsr166 integration. *From: *Stuart Marks *Date: *Thu, May 16, 2019 at 3:11 PM *To: *Martin Buchholz, David Holmes, Doug Lea, Langer, Christoph *Cc:

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

Hi Arthur, do we need "Integer.toString(4)" to convert int to string in SocksProxyVersion ? Thanks, Vyom On Fri, May 17, 2019 at 4:46 AM Arthur Eubanks wrote: > bug: https://bugs.openjdk.java.net/browse/JDK-8224081 > webrev: http://cr.openjdk.java.net/~aeubanks/8224081/webrev.00/index.html > > T

Re: [ipv6]: 8224019: test/jdk/java/nio/channels/DatagramChannel/BasicMulticastTests.java assumes IPv4 is always available

On 16/05/2019 23:38, Arthur Eubanks wrote: I've added testing exceptions to IPv6 as well, PTAL. This required hardcoding IPv4 and IPv6 loopback addresses for the IPv4 and IPv6 code paths. Else DatagramChannel.join() fails since you can't mix IPv4 and IPv6 addresses, and InetAddress.getLocalHost