RE: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Daniel, unfortunately, your proposed solution does not work with javac. I get this in the build: ...\mercurial\jdk\src\java.net.http\share\classes\jdk\internal\net\http\ExchangeImpl.java:103: error: method thenCompose in class CompletableFuture cannot be applied to given types;

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Christoph, On 13/05/2019 08:29, Langer, Christoph wrote: Hi Daniel, unfortunately, your proposed solution does not work with javac. I get this in the build: Oh darn. I should have double checked. Can we at least reduce the scope of the @SuppressedWarnings by introducing a private method t

[teststabilization] RFR: 8223632: Replace wildcard address with loopback or local host in tests - part 5

Hi, Please find below a fix for a bunch of tests that have been observed to fail intermittently. The usual trick (replacing wildcard with localhost) was applied. In some cases, the logic of the test meant that the trick could be applied only partially (e.g. it could be applied to the proxy, but

[teststabilization] RFR: 8223638: Replace wildcard address with loopback or local host in tests - part 6

Hi, Please help to review another part of test fixes to address intermittent  networking test failures. Webrev: http://cr.openjdk.java.net/~aefimov/8223638/00/index.html JBS: https://bugs.openjdk.java.net/browse/JDK-8223638 With Best Regards, Aleksei

Re: [teststabilization] RFR: 8223638: Replace wildcard address with loopback or local host in tests - part 6

Hi Aleksei, I believe that some configurations in the wild might return you the external host address when looking up "localhost". It doesn't matter if the server binds to the wildcard, but if you change the server to stop using the wildcard, then you also need to change the client to use the sam

Re: [teststabilization] RFR: 8223632: Replace wildcard address with loopback or local host in tests - part 5

Daniel, On 13/05/2019 14:58, Daniel Fuchs wrote: ... http://cr.openjdk.java.net/~dfuchs/webrev_8223632/webrev.00/ This looks ok to me. I'm happy to see these tests being improved, as I see them failing intermittently from time to time. Clearly there is some interference in your test runs. Pr

Re: [ipv6] RFR: 8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly

Arthur, On 11/05/2019 01:17, Arthur Eubanks wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8223737 Webrev: http://cr.openjdk.java.net/~aeubanks/8223737/webrev.00/index.html HostsFileNameService doesn't handle IPv6 literal addresses correctly. For example, ::1 and 0:0:0:0:0:0:0:1 should yi

RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

Hi, Please find below a fix for: [1] 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic Occasionally a test server may receive traffic that doesn't originate from the client in the test. If the client makes requests that are recogn

Re: [teststabilization] RFR: 8223638: Replace wildcard address with loopback or local host in tests - part 6

Hi Daniel, Thanks for all your comments. I've changed all the tests to address the concern about the "localhost" configurations. Plus, I've utilized URIBuilder where possible. Also tried keep the SimpleHttpServer simpler. The new version can be viewed here: http://cr.openjdk.java.net/~aefimov/

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

Hi Chris, Serguei, Updated webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.05/ CSR (approved): https://bugs.openjdk.java.net/browse/JDK-8223104 Changes (vs. webrev.04): - setsockopt(IPV6_V6ONLY) was moved from Win-specific code to shared setOptionsCommon function (in socketTransport.c)

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

Hi Alex, Thank you for the update! It looks good to me. Thanks, Serguei On 5/13/19 14:06, Alex Menkov wrote: Hi Chris, Serguei, Updated webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.05/ CSR (approved): https://bugs.openjdk.java.net/browse/JDK-8223104 Changes (vs. webrev.04): - se

Re: [ipv6] RFR: 8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly

Hi Arthur, Chris, just a note in passing, as you are well set on the changes, which is all good -- needs must, as they say. The current implementation is an emulation of the gethostbyname and gethostbyaddr lookup on /etc/hosts. The reverse lookup issue is also solved by adding an additional