Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

2019-05-11 Thread Chris Hegarty
> On 7 May 2019, at 19:40, serguei.spit...@oracle.com wrote: > > Hi guys, > > We need a couple of partial reviews for this enhancement: > > - From the net-dev to check IPv6-addresses related part. >It does not need to be a thorough review. >We need another pair of eyes to check for o

Re: [ipv6] RFR: 8223532: Don't try creating IPv4 sockets in NetworkInterface.c if IPv4 is not supported

2019-05-11 Thread Chris Hegarty
Arthur, > On 10 May 2019, at 17:37, Arthur Eubanks wrote: > > Sounds good. > New webrev: http://cr.openjdk.java.net/~aeubanks/8223532/webrev.03/ > > > This is almost exactly the changes we made internally to this file. Good that we eve