Hi,
please review a small change that I'd like to see in OpenJDK to get rid of
compilation errors in the Eclipse IDE.
It seems the root cause for the compilation errors is that javac would
sometimes widen capture variables and is hence able to compile the places that
I touch here. The EC4J com
Hi Arthur,
The idea looks reasonable to me - I believe the changes in
NetworkInterface.c should be OK.
However - I don't think the changes in net_util.c::DEF_JNI_OnLoad
are acceptable.
I'll question whether this is the right place to bail
out. I agree it would be nice to have some diagnostic
tha
Arthur,
On 07/05/2019 19:35, Arthur Eubanks wrote:
...
With help from Chris's references ([1]), I added a test with a policy
file that grants IPSupport permission to listen/resolve localhost:0, and
read the java.net.preferIPv4Stack system property. Without either
permission, the test fails
Hi Arthur,
On 07/05/2019 19:35, Arthur Eubanks wrote:
When you said "double checking" I thought it was some terminology
related to security managers (e.g. "double checked locking") :P
Oh - sorry I was not clear enough.
I looked through all the tests I modified for any references to security
Arthur, Daniel,
On 08/05/2019 11:45, Daniel Fuchs wrote:
Hi Arthur,
The idea looks reasonable to me - I believe the changes in
NetworkInterface.c should be OK.
I agree.
Now that I look at this again, I think it may also be reasonable to
consider EAFNOSUPPORT in a similar way to that of EPROT
On 08/05/2019 12:51, Chris Hegarty wrote:
While the vast majority of libnet.so is devoted to socket related
implementation, not all is. There are a small number of low-level pieces
of functionality that can be used with support for either IPv4 or IPv6
being present. The NIO implementation als
Alan,
On 01/05/2019 14:10, Alan Bateman wrote:
JEP 353 [1] is now a candidate and I would like to get the CSR [2]
finalized and the changes reviewed so that it can be targeted.
The webrev with the changes is here:
http://cr.openjdk.java.net/~alanb/8221481/1/webrev/index.html
This is a n
On 08/05/2019 17:02, Arthur Eubanks wrote:
http://cr.openjdk.java.net/~aeubanks/8220673/webrev.04/
LGTM.
best regards,
-- daniel
On 08/05/2019 16:25, Chris Hegarty wrote:
This is a nice. The code is well structured and much more readable than
the plain implementation.
Thanks for doing through the implementation.
:
NioSocketImpl.java
If configureBlocking returned a boolean, then an assert could be
written to ensure t
Hi,
Please find below another patch in the series for intermittently
failing tests:
8223573: Replace wildcard address with loopback or local host in
tests - part 4
https://bugs.openjdk.java.net/browse/JDK-8223573
patch:
http://cr.openjdk.java.net/~dfuchs/webrev_8223573/webrev.00/
best
On 08/05/2019 12:02, Chris Hegarty wrote:
:
New webrev: http://cr.openjdk.java.net/~aeubanks/8220673/webrev.03/
:
P.S. adding nio-dev since there are a few tests in that area
being updated.
Thanks for forwarding.
IPSupports.skipIfConcurrentConfigurationIsInvalid is a bit strange and I
thi
11 matches
Mail list logo
