This looks good to me Chris!
best regards,
-- daniel
On 17/03/2019 08:53, Chris Hegarty wrote:
This review is for a test only change. It resolves a rare intermittent
failure.
The issue is that the test creates, retrieves the local port, and
immediately closes a server socket. It then expects
This review request is to resolve a documentation regression in Java 9,
resulting from part of the changes for 8132478, where {@value
java.net.URLConnection#contentPathProp} was inadvertently replaced with
{@link java.net.URLConnection#contentPathProp}. The former will inline
with the constant fiel
This looks good to me too.
- Michael.
On 17/03/2019, 09:14, Chris Hegarty wrote:
This review request resolves an issue where IPv6 socket addresses, used
in socket connect, are not correctly enclosed in square brackets when
tunneling over HTTP.
http://cr.openjdk.java.net/~chegar/8220663/
-Chri
Hi Chris,
Change looks good to me.
Thanks,
Vyom
On Tue, Mar 19, 2019 at 4:12 PM Chris Hegarty
wrote:
> This review request is to resolve a documentation regression in Java 9,
> resulting from part of the changes for 8132478, where {@value
> java.net.URLConnection#contentPathProp} was inadverten
Hi Chris,
Looks good to me.
@value: this is an interesting tag to know!
Powerful, useful, maybe dangerous too?
In this case the value in question is held in a *private*
static final field.
So {@link } was clearly wrong. But because the field
is private some future maintainer might well be tempt
(Sorry for the late response, I keep getting sidetracked by other stuff)
Is there a reason you're trying to deprecate the URL constructors?
And if we end up not using the URL constructors, then I still think it
would be nice to have a test library, since it's easy to forget to add the
"[]". Unles
HandlerLoop should be run in othervm, as it sets the system-wide URL
protocol handler factory which could inadvertently affect subsequent
tests run in the same agentvm. An example of this is in the bug
description: https://bugs.openjdk.java.net/browse/JDK-8221098
$ hg diff test/jdk/java/net/URL/Ha
Looks okay, surprised this wasn't noticed before.
On 19/03/2019 20:43, Chris Hegarty wrote:
HandlerLoop should be run in othervm, as it sets the system-wide URL
protocol handler factory which could inadvertently affect subsequent
tests run in the same agentvm. An example of this is in the bug
de
Looks good to me.
On Tue, Mar 19, 2019 at 1:48 PM Alan Bateman
wrote:
> Looks okay, surprised this wasn't noticed before.
>
It was!
