Trivially, there should be a comma after the year. Just add it.
diff --git a/src/jdk.net/linux/classes/jdk/net/LinuxSocketOptions.java
b/src/jdk.net/linux/classes/jdk/net/LinuxSocketOptions.java
--- a/src/jdk.net/linux/classes/jdk/net/LinuxSocketOptions.java
+++ b/src/jdk.net/linux/classes/jdk/ne
Looks good Chris!
-- daniel
On 13/03/2019 12:09, Chris Hegarty wrote:
Trivially, there should be a comma after the year. Just add it.
On 13/03/2019 12:09, Chris Hegarty wrote:
Trivially, there should be a comma after the year. Just add it.
Looks okay.
Hi Vyom,
Sorry, the change already went in. I can do this in a followup change if
you'd like.
On Tue, Mar 12, 2019 at 8:04 PM Vyom Tiwari wrote:
> Hi Arthur,
>
> Changes looks good to me, one minor comment, in HTTPTestServer.java we
> can avoid new local variable (InetAddress address) .
>
> Th
Hi,
A fix for some sample code in MulticastSocket, which assumed that
String.length() == String.getBytes().length, which is not true for
non-ASCII Strings.
http://cr.openjdk.java.net/~aeubanks/8220585/webrev.00
Trivially, there should be a comma after the year. Just add it.
$ hg diff src/java.base/share/classes/jdk/ src/java.base/share/classes/sun
diff --git a/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java
b/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java
--- a/src/ja
Hi All,
I think having the enhanced reporting of socket connection failures driven
by "jdk.net.includeInExceptions" property is a huge step forward with
regards to the ability to debug Java networking applications.
For me however one piece seems to be missing: I am not sure if there is any
kind o
Looks good to me Chris!
cheers,
-- daniel
On 13/03/2019 17:04, Chris Hegarty wrote:
Trivially, there should be a comma after the year. Just add it.
+1
> On Mar 13, 2019, at 1:04 PM, Chris Hegarty wrote:
>
> Trivially, there should be a comma after the year. Just add it.
>
>
> $ hg diff src/java.base/share/classes/jdk/ src/java.base/share/classes/sun
> diff --git a/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java
> b/src/ja
Looks good to me.
On Wed, Mar 13, 2019 at 9:34 AM Arthur Eubanks wrote:
> Hi,
>
> A fix for some sample code in MulticastSocket, which assumed that
> String.length() == String.getBytes().length, which is not true for
> non-ASCII Strings.
>
> http://cr.openjdk.java.net/~aeubanks/8220585/webrev.00
Arthur,
On 13/03/2019 16:32, Arthur Eubanks wrote:
Hi,
A fix for some sample code in MulticastSocket, which assumed that
String.length() == String.getBytes().length, which is not true for
non-ASCII Strings.
http://cr.openjdk.java.net/~aeubanks/8220585/webrev.00
Looks good. Thanks.
-Chris
On Tue, Mar 12, 2019 at 12:21 PM Chris Hegarty
wrote:
>
> > Just curious, what tests did you run and under what environment?
>
> I ran all java/net, sun/net, com/sun/net/, and some nio. I'm have a bit
> of a hacky environment: a JDK build with IPV6_V6ONLY set to 1, and
> preferIPv6Addresses effec
I filed the 8220575 [1] that tracks "Correctly format test URI's that
contain a retrieved IPv6 address"
Regarding fixing tests that incorrectly use IPv6 addresses in URL's or
URI's, without enclosing the address within '[' and ']' ( square
brackets ). These IPv6 addresses typically come from eith
Hi Chris,
On 13/03/2019 17:32, Chris Hegarty wrote:
I think that is most cases
it should be possible to just replace the use of `getHostAddress` with
`getHostName`. This defers the actual lookup to the system configured
name service ( rather than trying to encode IPv6 addresses in the
test )
I
Hi Arthur,
On 13/03/2019 17:43, Arthur Eubanks wrote:
Martin suggested looping through all available loopback addresses rather
than hardcoding them. In that case we'll need helper test functions to
return loopback addresses (and test that it actually returns all
available loopback addresses).
Daniel,
On 13/03/2019 18:22, Daniel Fuchs wrote:
Hi Chris,
On 13/03/2019 17:32, Chris Hegarty wrote:
I think that is most cases
it should be possible to just replace the use of `getHostAddress` with
`getHostName`. This defers the actual lookup to the system configured
name service ( rather tha
Martin,
On 13/03/2019 17:29, Martin Buchholz wrote:
...
The difficulty of testing networking environments is an impediment to
progress.
Chris, you might want to publish your hacky changes as an experimental
patch in cr.openjdk.
I will do this, but, as I said, it is just a hack.
At Google
On Wed, Mar 13, 2019 at 11:49 AM Chris Hegarty
wrote:
>
> > At Google, we have our own hacks to test ipv6-only environments, based
> > on either LD_PRELOAD or eBPF (but it would take work to share them even
> > in minimally functional form)
>
> Maybe I can produce something similar and publish it
+1 (on the security class).
Thanks,
Max
> On Mar 14, 2019, at 1:10 AM, Lance Andersen wrote:
>
> +1
>> On Mar 13, 2019, at 1:04 PM, Chris Hegarty wrote:
>>
>> Trivially, there should be a comma after the year. Just add it.
>>
>>
>> $ hg diff src/java.base/share/classes/jdk/ src/java.base/sh
On Wed, Mar 13, 2019 at 11:24 AM Daniel Fuchs
wrote:
>
> jshell> InetAddress.getLoopbackAddress().getHostName()
> $7 ==> "localhost"
>
> jshell> InetAddress.getAllByName("localhost");
> $8 ==> InetAddress[3] {
>localhost/127.0.0.1,
>localhost/0:0:0:0:0:0:0:1,
>
20 matches
Mail list logo
