Re: RFR: 8217264: HttpClient: Blocking operations in mapper function do not work as documented

Daniel, On 23/01/2019 11:10, Daniel Fuchs wrote: Hi, Please find below a fix for: 8217264: HttpClient: Blocking operations in mapper function do not work as documented [1] https://bugs.openjdk.java.net/browse/JDK-8217264 webrev: [2] http://cr.openjdk.java.net/~dfuchs/webrev_8217264/

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

Hi Goetz, thanks for the review. I've added the comment as you suggested: http://cr.openjdk.java.net/~clanger/webrevs/8217657.1/ Will run it through our nightly tests before submitting... /Christoph From: Lindenmaier, Goetz Sent: Donnerstag, 24. Januar 2019 08:48 To: Langer, Christoph ; Open

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

Thanks! I should have stated that I don't need a new webrev, thanks anyways. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 24. Januar 2019 11:59 > To: Lindenmaier, Goetz ; OpenJDK Dev list > ; OpenJDK Network Dev list d...@openjdk.java.net> >

Re: RFR: 8216986 Remove unused code from SocksSocketImpl

I've updated the webrev at http://cr.openjdk.java.net/~michaelm/8216986/webrev.2/ to add some tests and also I found the same dubious implementation of getLocalPort() in HttpConnectSocketImpl.java. The test infrastructure needed some cleanup also. Thanks, Michael. On 23/01/2019, 14:30, Micha

Re: RFR: 8216986 Remove unused code from SocksSocketImpl

On 24/01/2019 13:09, Michael McMahon wrote: I've updated the webrev at http://cr.openjdk.java.net/~michaelm/8216986/webrev.2/ to add some tests and also I found the same dubious implementation of getLocalPort() in HttpConnectSocketImpl.java. The test infrastructure needed some cleanup also. Th

Re: RFR: 8216986 Remove unused code from SocksSocketImpl

On 24/01/2019, 14:38, Alan Bateman wrote: On 24/01/2019 13:09, Michael McMahon wrote: I've updated the webrev at http://cr.openjdk.java.net/~michaelm/8216986/webrev.2/ to add some tests and also I found the same dubious implementation of getLocalPort() in HttpConnectSocketImpl.java. The test

Re: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

I don't think you really need to run the test with the othervm flag, unless you are concerned other tests may be setting this property and (incorrectly) not running in a separate VM, which would be a bug in my opinion. Well, then maybe you should run it in othervm just in case. Otherwise, looks

RFR 8217740: SocksIPv6Test.java compilation error

Please review a quick fix for a test compilation error, as a side effect of 8216986. diff --git a/test/jdk/java/net/Socks/SocksIPv6Test.java b/test/jdk/java/net/Socks/SocksIPv6Test.java --- a/test/jdk/java/net/Socks/SocksIPv6Test.java +++ b/test/jdk/java/net/Socks/SocksIPv6Test.java @@ -173,7

Re: RFR 8217740: SocksIPv6Test.java compilation error

Verified against current repo. +1 Brian > On Jan 24, 2019, at 10:58 AM, Roger Riggs wrote: > > Please review a quick fix for a test compilation error, as a side effect of > 8216986. > > diff --git a/test/jdk/java/net/Socks/SocksIPv6Test.java > b/test/jdk/java/net/Socks/SocksIPv6Test.java >

Re: RFR 8217740: SocksIPv6Test.java compilation error

Thanks  Brian On 01/24/2019 02:19 PM, Brian Burkhalter wrote: Verified against current repo. +1 Brian On Jan 24, 2019, at 10:58 AM, Roger Riggs > wrote: Please review a quick fix for a test compilation error, as a side effect of 8216986. diff --git a/test/j

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

Hi Sean, thanks for looking at this. I agree. Will remove othervm... Best regards Christoph > -Original Message- > From: Sean Mullan > Sent: Donnerstag, 24. Januar 2019 17:43 > To: Langer, Christoph ; OpenJDK Dev list > ; OpenJDK Network Dev list d...@openjdk.java.net> > Subject: Re: R