Hi Ivan ,looks good to me too (not a Reviewer however).
Do you think we should address the other reallocs with unhandeled return code
?
Best regards, Matthias
> -Original Message-
> From: Langer, Christoph
> Sent: Dienstag, 15. Januar 2019 20:58
> To: Ivan Gerasimov ; Baesken, Matt
On 15/01/2019 16:52, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8217094: HttpClient SSL race if a socket IOException is raised
before ALPN is available
https://bugs.openjdk.java.net/browse/JDK-8217094
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8217094/webrev.00/
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8217237/webrev.1/
Thanks,
Michael
Hi Michael,
I believe the code changes looks good.
WRT to the test:
150 if (response.statusCode() != 200 &&
!response.body().equals(server.response())) {
I believe you meant || not &&
best regards,
-- daniel
On 16/01/2019 16:46, Michael McMahon wrote:
Could I get the following c
Thank you Christoph and Mattias!
I've filed
https://bugs.openjdk.java.net/browse/JDK-8217291 and
https://bugs.openjdk.java.net/browse/JDK-8217292
to handle the realloc() issues in other areas.
With kind regards,
Ivan
On 1/16/19 2:22 AM, Baesken, Matthias wrote:
Hi Ivan ,looks good to me too
