Hi Chris,
thanks for review, you are right, we should clear the pending exception
if -2 is return. Please find the latest
webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.2/index.html).
Thanks,
Vyom
On 15/11/18 9:57 PM, Chris Hegarty wrote:
Vyom,
On 13 Nov 2018, at 12:35, vyom
On 21/11/18 09:38, vyom tewari wrote:
Hi Chris,
thanks for review, you are right, we should clear the pending exception
if -2 is return. Please find the latest
webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.2/index.html).
Thank you. I think this is good.
-Chris.
Thanks to all for the feedback. It makes sense to reduce the scope of
the lock where possible.
I've updated the webrev :
http://cr.openjdk.java.net/~coffeys/webrev.8213942.v2/webrev/
Regards,
Sean.
On 20/11/18 20:59, Chris Hegarty wrote:
Sean,
On 20 Nov 2018, at 17:55, Seán Coffey wrote:
On 21/11/18 13:04, Seán Coffey wrote:
Thanks to all for the feedback. It makes sense to reduce the scope of
the lock where possible.
I've updated the webrev :
http://cr.openjdk.java.net/~coffeys/webrev.8213942.v2/webrev/
Thanks Sean, this looks good.
-Chris.
On 21/11/2018 13:04, Seán Coffey wrote:
Thanks to all for the feedback. It makes sense to reduce the scope of
the lock where possible.
I've updated the webrev :
http://cr.openjdk.java.net/~coffeys/webrev.8213942.v2/webrev/
Looks good to me too.
-Alan
This fix assumes handlers returned from defaultFactory are interchangeable and
that defaultFactory is thread-safe. If these assumptions are valid, looks good
to me.
> On 21 Nov 2018, at 14:31, Chris Hegarty wrote:
>
>
>> On 21/11/18 13:04, Seán Coffey wrote:
>> Thanks to all for the feedback.
Pavel,
On 21/11/18 15:33, Pavel Rappo wrote:
This fix assumes handlers returned from defaultFactory are interchangeable
The default factory will always return a handler instance of
the same type, when the requesting protocol is the same.
and that defaultFactory is thread-safe.
It is.
-Chr
