Hi Max,
On 13/11/2018 02:35, Weijun Wang wrote:
I'm scanning a file and downloading links inside:
lines.flapMap(x -> Stream.ofNullable(findURIFrom(x)))
.map(l -> download(c, l))
.forEach(f -> f.join());
CompletableFuture> download(HttpClient c, URI link) {
return c.sendAsync(H
> On 13 Nov 2018, at 02:45, Pavel Rappo wrote:
> ...
> http://cr.openjdk.java.net/~prappo/8213490/webrev.02/
Looks fine.
-Chris.
On 13/11/2018 11:13, Chris Hegarty wrote:
On 13 Nov 2018, at 02:45, Pavel Rappo wrote:
...
http://cr.openjdk.java.net/~prappo/8213490/webrev.02/
Looks fine.
I concur.
best regards,
-- daniel
-Chris.
On 12/11/2018 23:51, Pavel Rappo wrote:
Daniel, Alan,
I excluded the update from the draft to the RFC and created a separate bug
for it:
[P5] 8213757: Investigate the possibility of updating the reference to the
spec in java.net.Inet6Address
I added the changes to the URI class from JDK-
Hi Chris,
Thanks for review, please find the latest
webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html)
where i incorporated your suggestion. Now i am returning the different
error code(-2) if IP Helper Library function GetIfTable fails. I checked
the all other call sites
>
> That's what I would use too. Though Chris Y.'s suggestion below
> should also work:
>
> On 13/11/2018 03:41, Chris Yin wrote: > lines.flapMap(x ->
> Stream.ofNullable(findURIFrom(x)))
>>.map(l -> download(c, l))
>>.collect(Collectors.toList())
>>.forEach(f -> f.join());
>
> sinc
Thanks Pavel, looks good!
*src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java*
I wonder if 'I' needs to be capitalized, as it starts a sentence:
* Authenticator for a particular realm is single threaded.
- * ie. if multiple threads need to get credentials fr
Also, in
src/java.base/windows/classes/sun/net/dns/ResolverConfigurationImpl.java
-// Addreses have changed
+// Addresses have changed
Wasn't it meant to be singular? I.e. "Address has changed"
And the same thing on the line 84.
src/java.base/windows/native/libnet/net_util_md.c
+ *
reseeding again, looks like some problem with my email client.
Vyom
On 13/11/18 6:05 PM, vyom tewari wrote:
Hi Chris,
Thanks for review, please find the latest
webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html)
where i incorporated your suggestion. Now i am returning t
