HTTP/2 Concurrent streams question

2018-11-07 Thread Elias Schulze
Hi! Not sure if this is the right place to ask, please point me in the right direction if it's not. My question is regarding the IOException "too many concurrent streams" in Http2Connection line 440. Probably my understanding of HTTP/2 and net.http is wrong, but I expected the HttpClient to open n

Re: HTTP/2 Concurrent streams question

2018-11-07 Thread Michael McMahon
Hi, This is the right place to ask! It was implemented that way because RFC 7540 recommends that: Clients SHOULD NOT open more than one HTTP/2 connection to a given host and port pair, where the host is derived from a URI, a selected alternative service [ALT-SVC

Re: HTTP/2 Concurrent streams question

2018-11-07 Thread Simone Bordet
Hi, On Wed, Nov 7, 2018 at 11:44 AM Michael McMahon wrote: > > Hi, > > This is the right place to ask! It was implemented that way because RFC 7540 > recommends that: > >Clients SHOULD NOT open more than one HTTP/2 connection to a given >host and port pair, where the host is derived from

RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Pavel Rappo
Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8210493/webrev.00 This change fixes binding to interface-local and link-local IPv6 multicast addresses on Linux. Thanks, -Pavel

RFR [12] 8213418: Socket/ServerSocket supportedOptions does not work with custom SocketImpl

2018-11-07 Thread Chris Hegarty
Socket and ServerSocket supportedOptions() caches the supported options in a static field on the assumption that all implementations support the same set of options. This assumption is incorrect. The cache can be on a per-socket basis ( which has been implemented in the webrev ), or maybe even re

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Alan Bateman
On 07/11/2018 14:12, Pavel Rappo wrote: Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8210493/webrev.00 This change fixes binding to interface-local and link-local IPv6 multicast addresses on Linux. Does the comment at L806 need to be updated? Also the change

JDK-7014531

2018-11-07 Thread MUELLER-SCHRAMM Gerd
Hi, I’ve got a question regarding JDK-7014531. This bug is still open and after checking it against Java 11 still valid. Will it ever be fixed? I’ve took a look at the source code and the bug seems to be in DefaultProxySelector.c, Java_sun_net_

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Chris Hegarty
On 07/11/18 14:12, Pavel Rappo wrote: Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8210493/webrev.00 Thanks for doing this Pavel. The changes in the webrev look good to me. -Chris.

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Pavel Rappo
> On 7 Nov 2018, at 15:22, Alan Bateman wrote: > > Does the comment at L806 need to be updated? Also the change makes me > wondering about the 2.4 kernel support, maybe it is time to think about > dropping some of the older code path. Alan, Is that better? http://cr.openjdk.java.net/~prap

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Alan Bateman
On 07/11/2018 16:23, Pavel Rappo wrote: On 7 Nov 2018, at 15:22, Alan Bateman wrote: Does the comment at L806 need to be updated? Also the change makes me wondering about the 2.4 kernel support, maybe it is time to think about dropping some of the older code path. Alan, Is that better?

Re: HTTP/2 Concurrent streams question

2018-11-07 Thread Michael McMahon
That's useful feedback Simone. It sounds like this is a somewhat different issue though. How would you recommend determining when to open a new connection to maximise throughput? Thanks, Michael. On 07/11/2018, 12:00, Simone Bordet wrote: Hi, On Wed, Nov 7, 2018 at 11:44 AM Michael McMahon

Re: HTTP/2 Concurrent streams question

2018-11-07 Thread Simone Bordet
Hi, On Wed, Nov 7, 2018 at 7:09 PM Michael McMahon wrote: > > That's useful feedback Simone. It sounds like this is a somewhat > different issue though. > How would you recommend determining when to open a new connection to > maximise throughput? Opening a new connection and maximizing throughpu

Re: A new proposal to add methods to HttpsURLConnection to access SSLSession

2018-11-07 Thread Sean Mullan
On 11/5/18 1:52 PM, Xuelei Fan wrote: Hi Chris and Sean, There are a few feedback for the CSR approval.  I updated to use Optional for the returned value.  For more details, please refer to:   https://bugs.openjdk.java.net/browse/JDK-8213161   http://cr.openjdk.java.net/~xuelei/8212261/webr

Re: A new proposal to add methods to HttpsURLConnection to access SSLSession

2018-11-07 Thread Xuelei Fan
On 11/7/2018 1:30 PM, Sean Mullan wrote:    https://bugs.openjdk.java.net/browse/JDK-8213161    http://cr.openjdk.java.net/~xuelei/8212261/webrev.03/ I didn't see a test for SecureCacheResponse - is it possible? JDK does not have the reference implementation of SecureCacheResponse. You could