[httpclient] HTTP2: Memory Leak with Proxy

2018-08-07 Thread Albert Schimpf
Hi, I stumbled upon some strange behavior when using the new Java httpclient. The issue is very simple to reproduce. Send a GET request via a known bad proxy: HttpClient client = HttpClient.newBuilder()     .proxy(ProxySelector.of(BAD_PROXY))     .build(); Htt

Re: RFR [11] 8208391: Need to differentiate response and connect timeouts in HTTP Client API

2018-08-07 Thread Chris Hegarty
> On 4 Aug 2018, at 14:08, Jaikiran Pai wrote: > > ... > > Do you think this can be reworded a bit? Although I understand what's > being said here, the wording doesn't seem right. Maybe something like: > > * In the case where a new connection needs to be > established, if >

Re: [httpclient] HTTP2: Memory Leak with Proxy

2018-08-07 Thread Chris Hegarty
Hi Albert, Very strange indeed. Thanks for reporting it, I’ll investigate. What do your mean by “bad proxy”. What is bad about it, and how does it behave? -Chris. > On 7 Aug 2018, at 10:25, Albert Schimpf wrote: > > Hi, > > I stumbled upon some strange behavior when using the new Java httpc

Re: Code Review Request, JDK-8207009 SSLEngine#closeInbound mentions SSLException when no close_notify is received

2018-08-07 Thread Xuelei Fan
New webrev: http://cr.openjdk.java.net/~xuelei/8207009/webrev.03/ Thanks for a find of Tim Brooks, that the SSLEngine inbound/outbound status is incorrect if closing during handshake. The above webrev is trying to fix the problems. See more in the OpenJDK thread: http://mail.openjdk.java.net

Re: [httpclient] HTTP2: Memory Leak with Proxy

2018-08-07 Thread Albert Schimpf
Hi, by bad I mean that this proxy is the only one out of ~1000 proxies which causes this behavior. It's also the only one which causes SSLExceptions (General SSL engine problem) and EOFExceptions. I don't think that particular proxy is a valid proxy. Using curl indicates that this is a SSL ha

Re: [httpclient] HTTP2: Memory Leak with Proxy

2018-08-07 Thread Chris Hegarty
> On 7 Aug 2018, at 16:55, Albert Schimpf wrote: > > Hi, > > by bad I mean that this proxy is the only one out of ~1000 proxies which > causes this behavior. It's also the only one which causes SSLExceptions > (General SSL engine problem) and EOFExceptions. I don't think that particular > p

Re: [httpclient] HTTP2: Memory Leak with Proxy

2018-08-07 Thread Chris Hegarty
Albert, I haven’t yet looked at what happens in JDK 10, but just to say, since things have moved on a lot in JDK 11 EA, that the same test runs with a reasonable amount of memory and CPU with JDK 11 EA [1]. I updated the test a little, since some the names have been changed with the standardisa