Re: [PATCH] SOCK_CLOEXEC for opening sockets

2018-07-11 Thread Alan Bateman
This seems to cover the sockets created in libnet but there is also a usage in libnio that will need update. It might be cleaner to name it NET_Socket to be consistent with the other wrappers (NET_Bind, NET_SetSocketOpt, etc.). There are a lot of other file descriptors that you may run into. W

RE: [PATCH] SOCK_CLOEXEC for opening sockets

2018-07-11 Thread Andrew Luo
Sounds good. I've updated my patch: diff -r 95c0644a1c47 src/java.base/linux/native/libnio/fs/LinuxWatchService.c --- a/src/java.base/linux/native/libnio/fs/LinuxWatchService.cFri Jun 15 17:34:01 2018 -0700 +++ b/src/java.base/linux/native/libnio/fs/LinuxWatchService.c Wed Jul 11 01:46:03 2

Re: [PATCH] SOCK_CLOEXEC for opening sockets

2018-07-11 Thread Alan Bateman
On 12/07/2018 05:55, Andrew Luo wrote: Ok, fixed a few more places (and a bug where fcntl was being run on a -1 fd).  Patch is below, let me know if there’s any other suggestions/etc. The file system code should not be calling into NET_* functions. The changes to net_util_* will also need cl