New HttpClient API - does it handle preemptive auth?

2018-06-25 Thread Jaikiran Pai
I'm testing/integrating the latest OpenJDK upstream HttpClient implementation with one of the libraries I have. Thanks for fixing some of the issues I (and others) had raised before! Before the introduction of this new API, the HttpURLConnection (which acted as a basic minimal client for HTTP)

RE: RFR: 8205342: windows : potential memleaks in getAdapter(s) in NetworkInterface_winXP.c

2018-06-25 Thread Baesken, Matthias
Hi Ivan , I removed the memset calls as suggested by Thomas , makes the change even a little bit shorter ; and replaced the fix "100" by sizeof in the print calls . New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205342.2/ Best regards, Matthias From: Ivan Gerasimov [mailto:

Re: New HttpClient API - does it handle preemptive auth?

2018-06-25 Thread Daniel Fuchs
Hi Jaikiran, Yes - it does support preemptive auth, but only for basic authentication since only basic is supported out of the box. best regards, -- daniel On 25/06/2018 12:46, Jaikiran Pai wrote: I'm testing/integrating the latest OpenJDK upstream HttpClient implementation with one of the li

Re: RFR: 8205342: windows : potential memleaks in getAdapter(s) in NetworkInterface_winXP.c

2018-06-25 Thread Ivan Gerasimov
Thanks Matthias! The last webrev looks good to me! With kind regards, Ivan On 6/25/18 7:20 AM, Baesken, Matthias wrote: Hi Ivan , I removed the memset calls as suggested by Thomas , makes the change even a little bit shorter ; and replaced the fix “100” by sizeof in the print calls

Re: RFR: 8205342: windows : potential memleaks in getAdapter(s) in NetworkInterface_winXP.c

2018-06-25 Thread Alan Bateman
On 25/06/2018 15:20, Baesken, Matthias wrote: Hi Ivan ,  I removed the memset calls as suggested by Thomas , makes the change  even a little bit shorter ; and replaced the  fix  “100” by sizeof   in the print calls . New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205342.2/

Re: New HttpClient API - does it handle preemptive auth?

2018-06-25 Thread Jaikiran Pai
Thanks Daniel. -Jaikiran On 25/06/18 10:49 PM, Daniel Fuchs wrote: Hi Jaikiran, Yes - it does support preemptive auth, but only for basic authentication since only basic is supported out of the box. best regards, -- daniel On 25/06/2018 12:46, Jaikiran Pai wrote: I'm testing/integrating th