RE: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-30 Thread Langer, Christoph
Hi Thomas, thanks for reviewing. The test has also passed our internal testing. I'll run it through jdk-submit and then push it in the course of the day. Best regards Christoph > -Original Message- > From: Thomas Stüfe [mailto:thomas.stu...@gmail.com] > Sent: Freitag, 27. April 2018 18

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-30 Thread Chris Hegarty
On 30/04/18 09:00, Langer, Christoph wrote: ... Taking this input I have updated my webrev to round things up a little bit: http://cr.openjdk.java.net/~clanger/webrevs/8202181.1/ Thank you Christophe, this latest version looks good. I'll run some tests on it and report the results by tomorrow

RE: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-30 Thread Langer, Christoph
Hi Chris, thanks for looking at this. I just received positive confirmation from jdk-submit. Our internal tests did not show regressions as well. So I'll wait for word on your tests before submitting. Thanks Christoph > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@ora

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-30 Thread Chris Hegarty
On 30/04/18 11:07, Langer, Christoph wrote: Hi Chris, thanks for looking at this. I just received positive confirmation from jdk-submit. Our internal tests did not show regressions as well. So I'll wait for word on your tests before submitting. Do you have a link to the jdk-submit job, or an

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-30 Thread Chris Hegarty
On 30/04/18 10:44, Chris Hegarty wrote: On 30/04/18 09:00, Langer, Christoph wrote: ... Taking this input I have updated my webrev to round things up a little bit: http://cr.openjdk.java.net/~clanger/webrevs/8202181.1/ Thank you Christophe, this latest version looks good. I'll run some tests

RFR [11] 8202423: Small HTTP Client refresh

2018-04-30 Thread Chris Hegarty
A number of implementation changes have accumulated in the sandbox since the initial integration of the HTTP Client. The changes mainly consist of: - Test stabilization fixes. - Clean up of code left over from early prototyping. - Some small performance improvements. - General bug fixing. ht

Re: [PATCH] JDK-8201545 Clarify the return value of InetAddress.getByName/getAllName for empty host value

2018-04-30 Thread Chris Hegarty
On 23/04/18 12:33, Chris Hegarty wrote: Thanks Jaikiran, I think your patch looks good. I filed the following CSR to track the Java SE API ( javadoc ) change. https://bugs.openjdk.java.net/browse/JDK-8202139 Once approved, I can sponsor this for you. Pushed: http://hg.openjdk.java.net/jdk/jd