RE: RFR:8194298 Add support for per Socket configuration of TCP keepalive

2018-04-26 Thread Langer, Christoph
Hi Vyom, what about my suggestions for renaming? src/jdk.net/macosx/classes/jdk/net/UnixSocketOptions.java -> src/jdk.net/macosx/classes/jdk/net/MacOSXSocketOptions.java src/jdk.net/macosx/native/libextnet/UnixSocketOptions.c -> src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c This wo

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

2018-04-26 Thread vyom tewari
On Thursday 26 April 2018 03:48 PM, Langer, Christoph wrote: Hi Vyom, what about my suggestions for renaming? src/jdk.net/macosx/classes/jdk/net/UnixSocketOptions.java -> src/jdk.net/macosx/classes/jdk/net/MacOSXSocketOptions.java src/jdk.net/macosx/native/libextnet/UnixSocketOptions.c -> s

RE: RFR:8194298 Add support for per Socket configuration of TCP keepalive

2018-04-26 Thread Langer, Christoph
Ok, let's get some more opinions on that... 😊 > -Original Message- > From: vyom tewari [mailto:vyom.tew...@oracle.com] > Sent: Donnerstag, 26. April 2018 12:31 > To: Langer, Christoph ; Chris Hegarty > ; OpenJDK Network Dev list d...@openjdk.java.net> > Subject: Re: RFR:8194298 Add suppor

RE: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-26 Thread Langer, Christoph
Ping, can some reviewer please have a look at this small fix? Thanks Christoph From: Langer, Christoph Sent: Dienstag, 24. April 2018 11:39 To: net-dev@openjdk.java.net Subject: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-26 Thread Brian Burkhalter
Hi Christoph, This looks OK to me but probably a net-dev engineer should also comment. The bug needs a noreg label, e.g., noreg-cleanup. Brian On Apr 26, 2018, at 11:56 AM, Langer, Christoph wrote: > Ping, can some reviewer please have a look at this small fix? > […] > > Bug: https://bugs

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-26 Thread vyom tewari
Hi Christoph, On Tuesday 24 April 2018 04:45 PM, Langer, Christoph wrote: Hi Vyom, I think, it is intentional to handle case where return "hostname" is to large to fit in  array.  if you see the man page(http://man7.org/linux/man- pages/man2/gethostname.2.html) it says that it is unspecified

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-26 Thread Thomas Stüfe
Hi Christoph, code change makes sense. +1 on the "sizeof()" arg change. I would prefer it though if you would move the zero-termination out of the if/else altogether. Best Regards, Thomas On Tue, Apr 24, 2018 at 11:38 AM, Langer, Christoph wrote: > Hi, > > > > please help reviewing a small c

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-26 Thread Thomas Stüfe
On Fri, Apr 27, 2018 at 7:02 AM, Thomas Stüfe wrote: > Hi Christoph, > > code change makes sense. +1 on the "sizeof()" arg change. > > I would prefer it though if you would move the zero-termination out of > the if/else altogether. Disregard this last comment. What I meant was I would probably un

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-26 Thread Thomas Stüfe
On Fri, Apr 27, 2018 at 5:57 AM, vyom tewari wrote: > Hi Christoph, > > > On Tuesday 24 April 2018 04:45 PM, Langer, Christoph wrote: > > Hi Vyom, > > I think, it is intentional to handle case where return "hostname" is to > large to > fit in array. if you see the man page(http://man7.org/linux/

Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

2018-04-26 Thread vyom tewari
On Friday 27 April 2018 10:58 AM, Thomas Stüfe wrote: On Fri, Apr 27, 2018 at 5:57 AM, vyom tewari wrote: Hi Christoph, On Tuesday 24 April 2018 04:45 PM, Langer, Christoph wrote: Hi Vyom, I think, it is intentional to handle case where return "hostname" is to large to fit in array. if