Re: java.net.Socket should report the attempted address and port

2018-04-23 Thread Péter Gergely Horváth
Hi Tobias, Thank you for pointing me to that thread: it's good to have that context (it was sent before I joined the mailing list, so please bear with me). I understand the JDK developers want to be safe than sorry around reporting target addresses and I absolutely agree with that point. However

Re: RFR 8202091 : Rename DualStackPlainSocketImpl to PlainSocketImpl [win]

2018-04-23 Thread Chris Hegarty
On 20/04/18 21:40, Ivan Gerasimov wrote: The correct links to the Bug and webrev are: BUGURL: https://bugs.openjdk.java.net/browse/JDK-8202091 WEBREV: http://cr.openjdk.java.net/~igerasim/8202091/00/webrev/ This looks good. Thanks Ivan. -Chris.

Re: [PATCH] JDK-8201545 Clarify the return value of InetAddress.getByName/getAllName for empty host value

2018-04-23 Thread Chris Hegarty
Thanks Jaikiran, I think your patch looks good. I filed the following CSR to track the Java SE API ( javadoc ) change. https://bugs.openjdk.java.net/browse/JDK-8202139 Once approved, I can sponsor this for you. -Chris. On 20/04/18 11:08, Jaikiran Pai wrote: Hi, The attached patch addresses

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

2018-04-23 Thread vyom tewari
Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.1/index.html). I incorporated  most of the review comments. Thanks, Vyom On Wednesday 18 April 2018 07:44 PM, Chris Hegarty wrote: Vyom, On 13/04/18 10:50, vyom tewari wrote: Hi All, Please review the

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

2018-04-23 Thread Alan Bateman
On 23/04/2018 13:05, vyom tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.1/index.html). I incorporated  most of the review comments. This looks much better but I think the second paragraph of the spec of each option needs to be inverted so

[8u] RFR(XS): 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only

2018-04-23 Thread Langer, Christoph
Hi, I created a JDK 8 backport proposal for JDK-8201369: http://cr.openjdk.java.net/~clanger/webrevs/8201369-jdk8.0/ This is the Bug: https://bugs.openjdk.java.net/browse/JDK-8201369 The issue was recently discussed and reviewed here: http://mail.openjdk.java.net/pipermail/net-dev/2018-April/011

Re: java.net.Socket should report the attempted address and port

2018-04-23 Thread Michael McMahon
I agree we should do something about this. I will make some enquiries with the security folks here as to what might be permitted. I suspect either some kind of debugging property/switch to enable it, or the limited information only being provided when a security manager is enabled, might work.

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

2018-04-23 Thread Chris Hegarty
On 23/04/18 13:34, Alan Bateman wrote: On 23/04/2018 13:05, vyom tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.1/index.html). I incorporated most of the review comments. This looks much better but I think the second paragraph of the spec

Re: [8u] RFR(XS): 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only

2018-04-23 Thread Chris Hegarty
On 23/04/18 13:49, Langer, Christoph wrote: Hi, I created a JDK 8 backport proposal for JDK-8201369: http://cr.openjdk.java.net/~clanger/webrevs/8201369-jdk8.0/ This is the Bug: https://bugs.openjdk.java.net/browse/JDK-8201369 The issue was recently discussed and reviewed here: http://mail

Re: [PATCH] JDK-8201545 Clarify the return value of InetAddress.getByName/getAllName for empty host value

2018-04-23 Thread Jaikiran Pai
Thank you Chris. -Jaikiran On 23/04/18 5:03 PM, Chris Hegarty wrote: Thanks Jaikiran, I think your patch looks good. I filed the following CSR to track the Java SE API ( javadoc ) change. https://bugs.openjdk.java.net/browse/JDK-8202139 Once approved, I can sponsor this for you. -Chris. O

RFR 8202154 : Remove unused code in TwoStacksPlainDatagramSocketImpl.c

2018-04-23 Thread Ivan Gerasimov
Hello! Some code in TwoStacksPlainDatagramSocketImpl.c is only relevant for earlier versions of Windows, which are no longer supported as of JDK 11. This code can be safely removed. Also removing an unused argument at DualStackPlainDatagramSocketImpl.socketCreate(). Would you please help re

Re: RFR 8202154 : Remove unused code in java.base/windows/native/libnet

2018-04-23 Thread Ivan Gerasimov
Hello again! A few other files contain obsolete code, so they can be combined together in one fix. The webrev was updated in place: http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/ Here's the summary of additional changes: - sun.net.PortConfig.getLower()/getUpper() always return the sa

Re: RFR 8202154 : Remove unused code in java.base/windows/native/libnet

2018-04-23 Thread vyom tewari
Hi Ivan, code looks good to me, thanks for doing this cleanup. One minor comment, in PortConfig.java you can make defaultUpper& defaultLower as final.I see that Microsoft changed dynamic port range recently do we need to put some comment in PortConfig.java ? Thanks, Vyom On Tuesday 24 Apri