Hi Chris,
our testing didn’t show regressions. Are we good to push?
Best regards
Christoph
From: Chris Hegarty [mailto:chris.hega...@oracle.com]
Sent: Montag, 16. April 2018 16:39
To: Langer, Christoph
Cc: Srividya Shamaiah ; OpenJDK Network Dev list
Subject: Re: RFR(XS): 8201369: Inet4Addres
Vyom,
On 13/04/18 10:50, vyom tewari wrote:
Hi All,
Please review the below code.
BugId: https://bugs.openjdk.java.net/browse/JDK-8194298
webrev : http://cr.openjdk.java.net/~vtewari/8194298/webrev0.0/index.html
Here is some proposed wording for the JDK-specific extended socket
options
Christophe,
On 18/04/18 14:44, Langer, Christoph wrote:
Hi Chris,
our testing didn’t show regressions. Are we good to push?
My testing was positive too.
I am happy to see this pushed to jdk/jdk.
-Chris.
Thank you. Pushed: http://hg.openjdk.java.net/jdk/jdk/rev/a838e3707f3a
> -Original Message-
> From: Chris Hegarty [mailto:chris.hega...@oracle.com]
> Sent: Mittwoch, 18. April 2018 16:20
> To: Langer, Christoph
> Cc: Srividya Shamaiah ; OpenJDK Network Dev list
>
> Subject: Re: RFR(XS):
Hi Chris,
On Wednesday 18 April 2018 07:44 PM, Chris Hegarty wrote:
Vyom,
On 13/04/18 10:50, vyom tewari wrote:
Hi All,
Please review the below code.
BugId : https://bugs.openjdk.java.net/browse/JDK-8194298
webrev :
http://cr.openjdk.java.net/~vtewari/8194298/webrev0.0/index.html
Her
Ivan,
On 16/04/18 17:29, Ivan Gerasimov wrote:
...
WEBREV: http://cr.openjdk.java.net/~igerasim/8201510/00/webrev/
I think this is mostly good. Just one comment.
I'm not sure that this is correct.
--- OLD ---
60 String exclBindProp = AccessController.doPrivileged(
61
Thanks Chris and Christoph for your help inpushing this to jdk repo.
Thanks,
Srividya S
From: "Langer, Christoph"
To: Chris Hegarty
Cc: Srividya Shamaiah , OpenJDK Network Dev
list
Date: 18/04/2018 08:28 PM
Subject:RE: RFR(XS): 8201369: Inet4AddressImpl_getLoc