Hi Ivan,
I went through your changes and I really like this work.
Nothing to complain about - especially if there are no regressions with the
additional test coverage.
Best regards
Christoph
> -Original Message-
> From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of
>
Not sure if this is the right place to mention this.
Anyone notice that specifying a custom security manager at jvm start up
causes issues with service providers loading? If using the sun
PolicyFile implementation, the policy doesn't load due to the provider
failure, I have a custom policy i
Ivan,
> On 26 Mar 2018, at 23:08, Ivan Gerasimov wrote:
>
> Hello everyone!
>
> A few modifications were done to the patch.
> Below is the list of updated parts of the patch with comments about what has
> changed, comparing to the previous version of the patch.
>
> The patched JDK builds fine
Thank you Christoph and Chris for the review!
I made the following suggested changes:
- fdAccess made private static final in both TwoStacks and DualStack.
- removed redundant check IS_NULL(iaObj) at bind0 (indeed, the address
was already checked at Java level).
For now, I would prefer to keep
> On 27 Mar 2018, at 18:30, Ivan Gerasimov wrote:
>
> Thank you Christoph and Chris for the review!
>
> I made the following suggested changes:
> - fdAccess made private static final in both TwoStacks and DualStack.
> - removed redundant check IS_NULL(iaObj) at bind0 (indeed, the address was
>
Hi Chris,
Requiring a third party adapter for using Reactive Streams for WebSockets
is not the end of the world, so I don't want to push this too hard, we can
just agree to disagree. But there were a few small questions in your reply
that I'll answer.
> Will their backpressure mechanisms map to e
On 23 March 2018 at 04:36, Wenbo Zhu wrote:
>
> +1
>
> Message-based flow-control is unspecified by the websocket protocol; and
> exposing byte-based flow-control (via RS) as part of the WS API seems a
> rather questionable approach.
>
No one is suggesting a byte based flow control mechanism, RS
