Hi,
On Thu, Mar 22, 2018 at 1:57 PM, Chris Hegarty wrote:
>> Rather, I think that there should be a built in helper that allows Reactive
>> Streams to be added on top,
>
> I fully agree that a Reactive Streams WebSocket abstraction should be
> built on top. Where I disagree is that it needs to b
Simone,
Thank you for you comments.
On 23/03/18 08:28, Simone Bordet wrote:
Hi,
On Thu, Mar 22, 2018 at 1:57 PM, Chris Hegarty wrote:
Rather, I think that there should be a built in helper that allows Reactive
Streams to be added on top,
I fully agree that a Reactive Streams WebSocket abs
Given that JDK-8058965 removed the IPv6 support from
TwoStacksPlainSocketImpl, the native socketListen method no longer
needs to deal with the non-IPv4 code path. This simplifies the code,
brings it in line with the unix variants, and removes a possible
problematic code path that could close the s
On 23/03/2018 17:18, Chris Hegarty wrote:
Given that JDK-8058965 removed the IPv6 support from
TwoStacksPlainSocketImpl, the native socketListen method no longer
needs to deal with the non-IPv4 code path. This simplifies the code,
brings it in line with the unix variants, and removes a possible
Hi Chris!
I was about to submit a patch for 8198358 that heavily modifies
TwoStacksPlainSocketImpl to make it aligned with DualStackPlainSocketImpl.
That patch will also remove this problematic code.
I can rebase my patch, but wouldn't it be easier to proceed with that fix?
I'm going send th
Ivan,
On 23/03/18 18:38, Ivan Gerasimov wrote:
Hi Chris!
I was about to submit a patch for 8198358 that heavily modifies
TwoStacksPlainSocketImpl to make it aligned with DualStackPlainSocketImpl.
That patch will also remove this problematic code.
I can rebase my patch, but wouldn't it be ea
Hello!
I reverted the direction of the patch, and now TwoStacks implementation
is changed to mimic DualStack.
As part of this fix, I also added another @run line to several tests to
execute them with the option -Djava.net.preferIPv4Stack=true to make
sure both implementations work as expected.
Hi Chris!
On 3/23/18 11:48 AM, Chris Hegarty wrote:
Ivan,
On 23/03/18 18:38, Ivan Gerasimov wrote:
Hi Chris!
I was about to submit a patch for 8198358 that heavily modifies
TwoStacksPlainSocketImpl to make it aligned with
DualStackPlainSocketImpl.
That patch will also remove this problem
Ivan,
Thank you for persisting with this.
> On 23 Mar 2018, at 19:09, Ivan Gerasimov wrote:
>
> Hello!
>
> I reverted the direction of the patch, and now TwoStacks implementation is
> changed to mimic DualStack.
> As part of this fix, I also added another @run line to several tests to
> exec
