Re: RFE: Add PATCH to the list of the supported HTTP methods

2018-03-07 Thread Andrej Golovnin
Hi Chris, > The JDK HTTP Client has: > `HttpRequest.Builder::method(String method, BodyPublisher publisher)` > > ,so it is currently possible to use the `PATCH` method. > > Is `PATCH` sufficiently popular to warrant its own self-named > method in the request builder? I don't know how popular i

Re: httpserver does not close connections when RejectedExecutionException occurs

2018-03-07 Thread Daniel Fuchs
Hi Yuji, On 07/03/2018 01:07, KUBOTA Yuji wrote: Nice catch! I removed this unused variable. http://cr.openjdk.java.net/~ykubota/8169358/webrev.04/ Best regards Yuji This looks good to me as well. I have imported your patch and sent it to our test system and things are looking fine. Could y

Re: httpserver does not close connections when RejectedExecutionException occurs

2018-03-07 Thread Chris Hegarty
On 07/03/18 01:07, KUBOTA Yuji wrote: .. Nice catch! I removed this unused variable. http://cr.openjdk.java.net/~ykubota/8169358/webrev.04/ I think is good. Thanks. -Chris.

Re: httpserver does not close connections when RejectedExecutionException occurs

2018-03-07 Thread KUBOTA Yuji
Hi Daniel, Thank you for your sponsoring! 2018-03-08 0:56 GMT+09:00 Daniel Fuchs : > Could you prepare a final changeset with a properly formatted > comment [1], use jcheck [2] to verify that your changeset conforms > to the OpenJDK rules (no trailing whitespaces, no tabs etc...), > and upload it

RE: httpserver does not close connections when RejectedExecutionException occurs

2018-03-07 Thread Langer, Christoph
Hi Yuji, looks good. Best regards Christoph > -Original Message- > From: KUBOTA Yuji [mailto:kubota.y...@gmail.com] > Sent: Donnerstag, 8. März 2018 03:57 > To: Daniel Fuchs > Cc: Langer, Christoph ; Yasumasa Suenaga > ; OpenJDK Network Dev list d...@openjdk.java.net> > Subject: Re: ht