Hi Gary,
I was having a look at your changes.
I'm wondering what the reason is behind uncommenting WSASendDisconnect in
Java_sun_nio_ch_SocketDispatcher_preClose0 of file SocketDispatcher.c? And in
dbgsysSocketClose?
In socketTransport.c, line:
331 setLastError(0, "gethostb
First pass over the code I disabled the compilation flag and then
did quick substitution for the easier functions. I commented out the
WSASendDisconnect calls so I could see what tests would fail if
the function was just removed. I have a replacement now that uses
"shutdown(fd,SD_SEND)", but I sti
But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it?
I still don't see the reason...
-Original Message-
From: gary.ad...@oracle.com [mailto:gary.ad...@oracle.com]
Sent: Donnerstag, 1. Februar 2018 12:17
To: Langer, Christoph ; OpenJDK Serviceability
; OpenJDK B
On 2/1/18, 6:59 AM, Langer, Christoph wrote:
But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it?
I still don't see the reason...
vs2013 include/um/winsock2.h has WSASendDisconnect deprecated.
.../src/jdk.jdwp.agent/windows/native/libdt_socket/socket_md.c(230) :
erro
Hi Roger,
> On 31 Jan 2018, at 15:52, Roger Riggs wrote:
>
> Adding net-dev@openjdk.java.net
>
> On 1/30/2018 5:08 PM, Roger Riggs wrote:
>> Please review changes to replace finalizers in socket, datagram, and
>> multicast networking
>> with Cleaner based release of the raw file descriptors.
Here's a revised webrev
http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html
Still testing ...
Using shutdown() fixed problems reported by the
java/nio/channelSocketChannel tests.
I also noticed prior use of getaddrinfo for "localhost" was not calling
freeaddrinfo.
...
On 2/
Hi Chris,
Thanks for the review and suggestion.
Webrev updated:
http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/
* Refactored SocketCleanup into a java.net package private SocketCleanable
* Moved register and unregister into static methods in SocketCleanable
* Simplified the
