Re: JEP 321: HTTP Client (Standard)

2017-12-05 Thread Alan Bateman
On 04/12/2017 21:56, David Lloyd wrote: : I've had opportunity to give feedback, perhaps, though the API always seemed incomplete. At least nobody (that I saw) sent out a message saying "Here it is, it's all done, what do you think?". I've certainly never had opportunity to try it out: given it

Re: RFR: 8193034: Optimize URL.toExternalForm

2017-12-05 Thread Chris Hegarty
> On 5 Dec 2017, at 04:01, Martin Buchholz wrote: > > http://cr.openjdk.java.net/~martin/webrevs/jdk/URL.toExternalForm/ Since the motivation for this change is performance, do you have any performance numbers / benchmarks that you can share? -Chris.

Re: JEP 321: HTTP Client (Standard)

2017-12-05 Thread Chris Hegarty
> On 4 Dec 2017, at 23:09, David Lloyd wrote: >> ... > > Thanks. If you don't mind answering one more question: is there any > possibility to intercept authentication completely? As with HttpURLConnection, if no Authenticator is set then, application code should be able to manually inspect a

Re: RFR: 8193034: Optimize URL.toExternalForm

2017-12-05 Thread Alan Bateman
On 05/12/2017 04:01, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/jdk/URL.toExternalForm/ The style is interesting but I don't see anything obvious wrong. -Alan

Re: JEP 321: HTTP Client (Standard)

2017-12-05 Thread dalibor topic
On 04.12.2017 22:56, David Lloyd wrote: saying "Here it is, it's all done, what do you think?". I've certainly never had opportunity to try it out: given its status as an incubating module present only in OpenJDK, the only people who are really in a position to try it out are those using OpenJDK

Re: JEP 321: HTTP Client (Standard)

2017-12-05 Thread David Lloyd
On Tue, Dec 5, 2017 at 5:48 AM, dalibor topic wrote: > On 04.12.2017 22:56, David Lloyd wrote: >> >> saying "Here it is, it's all done, what do you think?". I've >> certainly never had opportunity to try it out: given its status as an >> incubating module present only in OpenJDK, the only people

Re: JEP 321: HTTP Client (Standard)

2017-12-05 Thread dalibor topic
On 05.12.2017 14:48, David Lloyd wrote: On Tue, Dec 5, 2017 at 5:48 AM, dalibor topic wrote: On 04.12.2017 22:56, David Lloyd wrote: saying "Here it is, it's all done, what do you think?". I've certainly never had opportunity to try it out: given its status as an incubating module present