Hi Roger,
thanks for looking. So you motivated me to do some more cleanup. :)
Here is the new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8155590.1/
I replaced the Stack with an ArrayDeque and did some more rather cosmetical
changes to make KeepAliveCache more appealing. I verified the ch
Hi Vyom,
I just looked at your latest webrev which in general looks fine to me. Some
minor remarks:
make/lib/Lib-jdk.net.gmk:
- copyright year needs to be updated
src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java:
- private void addExtSocketOptions(...) looks a bit awful concern
Hi Christoph,
Looks ok.
The comment in remove() about CCE can be removed. ArrayDeque is not
thread safe
and doesn't check for CCE (and the method is synchronized).
Thanks, Roger
On 10/18/17 6:05 AM, Langer, Christoph wrote:
Hi Roger,
thanks for looking. So you motivated me to do some mo
Hi Roger,
maybe we have a little disconnect here in understanding. I thought you mean
ClassCastException with CCE but I don't see this mentioned anywhere. My comment
talks about ConcurrentModificationException (CME). I mentioned that because,
when the Collection is modified while iterating (whi
Hi Christoph,
Right, my mistake, I meant CME. My point was that ArrayDeque does not
throw CME from remove().
It is not multi-thread safe and does not check for CME.
That remove might have been coded using the iterator:
synchronized boolean remove(HttpClient h) {
for (Iterator it =this.i
Hi All,
please find the latest
webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.7/index.html).
Thanks,
Vyom
On Wednesday 18 October 2017 08:21 PM, Langer, Christoph wrote:
Hi Vyom,
I just looked at your latest webrev which in general looks fine to me. Some
minor remarks:
make
Hi Vyom,
looks good to me.
Best regards
Christoph
> -Original Message-
> From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of
> vyom tewari
> Sent: Donnerstag, 19. Oktober 2017 04:56
> To: net-dev@openjdk.java.net
> Subject: Re: RFR 8145635 : Add TCP_QUICKACK socket optio
