Re: RFR 8145635 : Add TCP_QUICKACK socket option

2017-10-17 Thread vyom tewari
Hi Roger, Thanks for the review , please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.6/index.html). Thanks, Vyom On Tuesday 17 October 2017 06:35 AM, Roger Riggs wrote: Hi Vyom, A few suggestions: PlainDatagramSocketImpl.java:  - line 95/96:  I think you c

Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-17 Thread Roger Riggs
Hi, Keep the synchronized, it will be low overhead since the Vector operations are synchronized and in the same thread. I think a CCE could occur during the iteration to find the entry when Vector.Itr.next() checks. (It you want to more radical fix, replace the Vector with something more cur