Re: [JDK 10] RFR: 8185794: java/net/httpclient/security/Driver.java fails in timeout

2017-08-04 Thread Daniel Fuchs
Hi Felix, On 04/08/2017 06:26, Felix Yang wrote: Hi Daniel, two comments: 1. you may need to change the copy right year from 2016 to 2017 Good point. Will do before pushing. 2. If I remember correctly, Chris suggested to add copyright to all policy files. Probably you can add together

Re: RFR 8184285: Buffer sizes of Flow based BodyProcessor API

2017-08-04 Thread Michael McMahon
Hi Tobias, On 04/08/2017, 10:22, Tobias Thierer wrote: Hi Michael - thanks for your work! The fact that BufferingProcessor wraps another BodyPro

Re: RFR 8184285: Buffer sizes of Flow based BodyProcessor API

2017-08-04 Thread Michael McMahon
On 04/08/2017, 10:22, Tobias Thierer wrote: Hi Michael - thanks for your work! The fact that BufferingProcessor wraps another BodyProcessor loo

Re: [JDK 10] RFR: 8185794: java/net/httpclient/security/Driver.java fails in timeout

2017-08-04 Thread Michael McMahon
Seems strange that the test needs more than 60 sec Daniel. But if that fixes it, it looks good. Thanks, Michael On 03/08/2017, 19:21, Daniel Fuchs wrote: Hi, Please find below a fix for a test bug: https://bugs.openjdk.java.net/browse/JDK-8185794 8185794: java/net/httpclient/security/Driver.j

[JDK 10] RFR: 8185852: HttpConnection should resolve addresses before SocketChannel.connect() is called

2017-08-04 Thread Daniel Fuchs
Hi, Please find below a small fix for 8185852: HttpConnection should resolve addresses before SocketChannel.connect() is called https://bugs.openjdk.java.net/browse/JDK-8185852 http://cr.openjdk.java.net/~dfuchs/webrev_8185852/webrev.00/ The issue here is that ProxySelector.getDefault() may r

Re: [JDK 10] RFR: 8185852: HttpConnection should resolve addresses before SocketChannel.connect() is called

2017-08-04 Thread Chris Hegarty
> On 4 Aug 2017, at 10:14, Daniel Fuchs wrote: > > Hi, > > Please find below a small fix for > 8185852: HttpConnection should resolve addresses before > SocketChannel.connect() is called > https://bugs.openjdk.java.net/browse/JDK-8185852 > > http://cr.openjdk.java.net/~dfuchs/webrev_8185852/w