Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Thanks:-) -Felix On 2017/6/1 16:32, Felix Yang wrote: Hi there, please review the patch convert several sun/net shell tests to plain java tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8181080 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/ Thanks, Felix

Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

sun/net/www/protocol/file/DirPermissionDenied.java + + @BeforeTest + public void setup() throws Throwable { + // mkdir and chmod "333" + Files.createDirectories(TEST_DIR); + ProcessTools.executeCommand("chmod", "333", TEST_DIR.toString()) Maybe just do this with java api instead run chmod comman

RFR 8181635/10, sun/net/www/protocol/jar/B6449504.java fails at Windows platform (after JDK-8181414)

Hi, please review the patch to make the test run with othervm mode. It has been observed to be failing in agentvm mode, because Jar connection is not closed in prior test. Bug: https://bugs.openjdk.java.net/browse/JDK-8181635 Patch: --- old/test/sun/net/www/protocol/jar/B6449504.java

Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Amy, thanks for the comments. On 2017/6/6 10:37, Amy Lu wrote: sun/net/www/protocol/file/DirPermissionDenied.java + + @BeforeTest + public void setup() throws Throwable { + // mkdir and chmod "333" + Files.createDirectories(TEST_DIR); + ProcessTools.executeCommand("chmod", "333", TEST_DIR.