Re: RFR [9] 8180155: WebSocket secure connection get stuck after onOpen

2017-06-01 Thread Pavel Rappo
Hi Daniel, Thanks a lot for looking into this! I agree there's an issue exactly where you pointed at. I'm sure it would be a good idea to write a test that covers this. Unfortunately it would be quite a challenging task. I tried to rewrite the state machine the way that both fixes this bug and ma

Re: RFR [9] 8180155: WebSocket secure connection get stuck after onOpen

2017-06-01 Thread Daniel Fuchs
Hi Pavel, On 01/06/2017 12:32, Pavel Rappo wrote: Hi Daniel, Thanks a lot for looking into this! I agree there's an issue exactly where you pointed at. I'm sure it would be a good idea to write a test that covers this. Unfortunately it would be quite a challenging task. I agree it would be go

Re: RFR [9] 8180155: WebSocket secure connection get stuck after onOpen

2017-06-01 Thread Pavel Rappo
> On 1 Jun 2017, at 13:45, Daniel Fuchs wrote: > > Hi Pavel, > > I agree it would be good to have a test :-( > These kind of complex state logic have a tendency to > bite you if you only test them by code reading. True. The thing is I would refrain from writing a black-box test in this case. T

Re: RFR [9] 8180155: WebSocket secure connection get stuck after onOpen

2017-06-01 Thread Daniel Fuchs
OK Pavel, Then this looks good. -- daniel On 01/06/2017 14:48, Pavel Rappo wrote: On 1 Jun 2017, at 13:45, Daniel Fuchs wrote: Hi Pavel, I agree it would be good to have a test :-( These kind of complex state logic have a tendency to bite you if you only test them by code reading. True.