Hi there,
please review following patch to convert all shell cases under
java/net to plain java codes.
Webrev:
http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.00/
Bug:
https://bugs.openjdk.java.net/browse/JDK-8166139
Thanks,
Felix
Hi Felix,
closetest/CloseTest:
32: Please put the @modules directives together (and not repeat)
44: do not use wildcard imports (reconfigure your IDE if necessary to
avoid accidents).
63: setup() is invoked twice... remove 1 or explain why 2 calls
69, 78,90,91,... : space in method call
Hi Roger,
please review the updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.01/
Thanks,
Felix
On 2017/5/26 3:24, Roger Riggs wrote:
Hi Felix,
closetest/CloseTest:
32: Please put the @modules directives together (and not repeat)
Fixed
-Felix
44: do not use wildcard
Hi, Felix
I noticed that CompilerUtils from jdk/test/lib/testlibrary is still used
in tests. It’s better to use the version [1] from top level.
(Not a reviewer.)
Thanks,
Amy
[1]
http://hg.openjdk.java.net/jdk10/jdk10/file/tip/test/lib/jdk/test/lib/compiler/CompilerUtils.java
On 5/26/17 11
Hi Amy,
it is intended, because in my changes CompilerUtils is usually used
together with JarUtils, which has not been moved yet. It is a bit
confusing to add two lib directories, and even there are files with the
same name. So it may be clearer to refactor lib usage unified in
JDK-807532
